OpenStack Dashboard (Horizon)

heat stacks are not appropriately sorted by "Created" field

Bug #1713748 reported by Pavlo Shchelokovskyy on 2017-08-29

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	Pavlo Shchelokovskyy	OpenStack Dashboard (Horizon) queens-2

Bug Description

It seems the "Created" field is being treated as a numeric tuple,
and thus currently when sorting the stacks table on "Created" column we have:

24 minutes > 5 days > 2 weeks
and
5 hours, 37 minutes > 5 hours, 4 hours

Instead this field should be treated as proper date.

See original description

Tags:

Pavlo Shchelokovskyy (pshchelo) on 2017-08-29

Changed in horizon:
assignee:	nobody → Pavlo Shchelokovskyy (pshchelo)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-29: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/498838

Changed in horizon:
status:	New → In Progress

Pavlo Shchelokovskyy (pshchelo) on 2017-08-30

description:

updated

Revision history for this message

Kyrylo Romanenko (kromanenko) wrote on 2017-08-30:

Checked patch by applying code manually on working Horizon. It works as expected with this patch.

Gary W. Smith (gary-w-smith) on 2017-09-18

Changed in horizon:
importance:	Undecided → Medium

Akihiro Motoki (amotoki) on 2017-10-24

Changed in horizon:
milestone:	none → queens-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-24: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/498838
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=bfd66305ce7f8240a04eacf4f6349f2c7186ab90
Submitter: Zuul
Branch: master

commit bfd66305ce7f8240a04eacf4f6349f2c7186ab90
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Aug 29 15:08:34 2017 +0000

Properly sort Heat stacks on Created field

    replace the 'timesince_or_never' filter with 'timesince_sorted' one as the
    creation_time attribute of a Heat stack can not actually be None.
    Also add a 'timesince' data-type to this field.

Change-Id: I9727254b4c255331562083f957133ed6e3cd7e90
Closes-Bug: #1713748

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-27: Fix proposed to horizon (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/515645

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-31: Fix merged to horizon (stable/pike)

Reviewed: https://review.openstack.org/515645
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0712ed3b8c6193ca4978becf70da62c6c31edabc
Submitter: Zuul
Branch: stable/pike

commit 0712ed3b8c6193ca4978becf70da62c6c31edabc
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Tue Aug 29 15:08:34 2017 +0000

Properly sort Heat stacks on Created field

    replace the 'timesince_or_never' filter with 'timesince_sorted' one as the
    creation_time attribute of a Heat stack can not actually be None.
    Also add a 'timesince' data-type to this field.

    Change-Id: I9727254b4c255331562083f957133ed6e3cd7e90
    Closes-Bug: #1713748
    (cherry picked from commit bfd66305ce7f8240a04eacf4f6349f2c7186ab90)