task status change incorrectly reported in info log message

Bug #1713740 reported by Brian Rosmaita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Brian Rosmaita

Bug Description

This is minor but annoying. The INFO message reporting the status change of a task always looks like this:

2017-08-29 09:49:22.561 INFO glance.domain [-] Task [9cc88fb7-eb80-48e9-8bfd-be68bdbadb7f] status changing from processing to processing
2017-08-29 09:49:24.700 INFO glance.domain [-] Task [9cc88fb7-eb80-48e9-8bfd-be68bdbadb7f] status changing from success to success

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/498839

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/498839
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=e1321298e7899d0d0d6b96243935454c427e2464
Submitter: Jenkins
Branch: master

commit e1321298e7899d0d0d6b96243935454c427e2464
Author: Brian Rosmaita <email address hidden>
Date: Tue Aug 29 11:10:22 2017 -0400

    Change variable used by log message

    The code was changing the status of a task and then logging an
    info message about the change using the already-changed variable.
    This patch saves the old status before the task status is modified
    so that the status transition can be accurately reported in the log.

    Change-Id: I84fef1d710f24f601971a348f53d74b6a6d6a2f9
    Closes-bug: #1713740

Changed in glance:
status: In Progress → Fix Released
Changed in glance:
milestone: none → queens-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 16.0.0.0b1

This issue was fixed in the openstack/glance 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.