Warning message is not shown on launch instance modal

[Ying Zuo]

Steps to reproduce:

1. Create an image required minimum 10GB disk.
2. Open up angular launch instance modal and select boot from image as boot source.
3. Go to the flavor tab and there should be a warning icon shown for the flavor m1.tiny.

Expect to see a warning message when hovered over the icon but that doesn't happen.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/500437

[Akihiro Motoki (amotoki)]

I am not sure the scenario reported in the bug description is valid.

In my understanding the scenarios will be different depending on whether boot from volume is used or not.
In case of boot from volume, flavor configuration does not affect the disk size directly and I think we can launch an instance if we create a enough size of volume.
In case of non boot from volume case (ephemeral disk case), the flavor configuration decides the disk size. In this case, we need to show proper warning message.

Am I missing something?

[Ying Zuo (yingzuo)]

Hi Akihiro,

The issue that this ticket is trying to fix is a pure UI issue. Basically, whenever there's a warning icon(yellow triangle) shown for some flavors on launch instance modal, the warning message should be shown when hovering over the icon. Right now the warning message is not showing because the syntax for the popover is different now. https://github.com/angular-ui/bootstrap/tree/master/src/popover

[Akihiro Motoki (amotoki)]

Thanks Ying for clarifying the situation. Sounds reasonable.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/500437
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9c3d01a77cdbd64843afc81491f39bdfe1293672
Submitter: Zuul
Branch: master

commit 9c3d01a77cdbd64843afc81491f39bdfe1293672
Author: Ying Zuo <email address hidden>
Date: Sun Sep 3 21:22:01 2017 -0700

    Fix warning message not showing on launch instance modal

    The warning message should be shown when hovering over the
    warning icon on launch instance modal.

    Updated the name and attribute of the popover directive.

    Change-Id: Ida5b7aad33c6024d8bdd1ea6d1cb2b35b9fd6ba6
    Closes-bug: #1713591

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0b3 development milestone.