Allow to set OPENSTACK_KEYSTONE_DEFAULT_DOMAIN and OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT=False even with Keystone v3

Bug #1712999 reported by Nobuto Murata
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard Charm
Fix Released
Wishlist
Michael Skalka

Bug Description

When considering a single domain usecase for users (admin_domain for administration, then example_domain for all other users), it would be handy for users not to input their domain name, but only username and password to login.

By setting two lines below, we can create a separate dashboard instance for non-admin users only.

OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT=False
OPENSTACK_KEYSTONE_DEFAULT_DOMAIN=example_domain

However, the current local_settings.py template does not allow that.

====
OPENSTACK_HOST = "{{ service_host }}"
OPENSTACK_KEYSTONE_DEFAULT_ROLE = "{{ default_role }}"
{% if api_version == "3" -%}
OPENSTACK_KEYSTONE_URL = "{{ service_protocol }}://%s:{{ service_port }}/v3" % OPENSTACK_HOST
OPENSTACK_API_VERSIONS = { "identity": 3, }
OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT = True
OPENSTACK_KEYSTONE_DEFAULT_DOMAIN = "{{ admin_domain_id }}"
{% else -%}
OPENSTACK_KEYSTONE_URL = "{{ service_protocol }}://%s:{{ service_port }}/v2.0" % OPENSTACK_HOST
{% endif -%}
====

Tags: cpe-onsite
Chris Gregan (cgregan)
tags: added: cpe-onsite
Michael Skalka (mskalka)
Changed in charm-openstack-dashboard:
assignee: nobody → Michael Skalka (mskalka)
Revision history for this message
Nobuto Murata (nobuto) wrote :
James Page (james-page)
Changed in charm-openstack-dashboard:
status: New → In Progress
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-openstack-dashboard (master)

Reviewed: https://review.openstack.org/506259
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=780381e6c4fffddbe5c7e4a43d213c63f687de82
Submitter: Zuul
Branch: master

commit 780381e6c4fffddbe5c7e4a43d213c63f687de82
Author: Michael Skalka <email address hidden>
Date: Thu Sep 21 11:19:18 2017 -0400

    Add default_domain config option.

    This commit adds the default-domain config option to limit
    the login page to only the specifed domain. For use with a single
    domain environment where users are only given a login.

    When considering a single domain usecase for users (admin_domain for
    administration, then example_domain for all other users), it would
    be handy for users not to input their domain name, but only username
    and password to login.

    By setting two lines below, we can create a separate dashboard instance
    for non-admin users only.

    OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT=False
    OPENSTACK_KEYSTONE_DEFAULT_DOMAIN=example_domain

    However, the current local_settings.py template does not allow that.

    This change adds the 'default-domain' configuration option which modifies
    local_policy.py to set the two configuration flags outlined in the bug.
    If the config option is not set the charm will behave as before, enabling
    the user to specify the domain at login.

    This does no validation to ensure the domain exists, so it is up to the user
    to supply a valid domain name.

    Closes-Bug: 1712999
    Change-Id: I316372ae305a4ba10e4d8ba047f23a317836b960

Changed in charm-openstack-dashboard:
status: In Progress → Fix Committed
James Page (james-page)
Changed in charm-openstack-dashboard:
milestone: none → 17.11
James Page (james-page)
Changed in charm-openstack-dashboard:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-openstack-dashboard (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/535865

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-openstack-dashboard (master)

Reviewed: https://review.openstack.org/535865
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=48119619a0df4445432bfcbcb0a5a0a585226774
Submitter: Zuul
Branch: master

commit 48119619a0df4445432bfcbcb0a5a0a585226774
Author: Nobuto Murata <email address hidden>
Date: Fri Jan 19 17:31:30 2018 +0000

    OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT expects boolean

    Previously the single domain mode has been implemented. This is a
    follow-up commit to set the value properly as boolean instead of string.

    Change-Id: I0e34d93d05693bf0ca5e8f68bc9af198fd29680a
    Closes-Bug: #1744346
    Related-Bug: #1712999

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to charm-openstack-dashboard (stable/17.11)

Related fix proposed to branch: stable/17.11
Review: https://review.openstack.org/539410

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to charm-openstack-dashboard (stable/17.11)

Reviewed: https://review.openstack.org/539410
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=e4b809bcf1b6998c8a6aea06fab66f8abd18872b
Submitter: Zuul
Branch: stable/17.11

commit e4b809bcf1b6998c8a6aea06fab66f8abd18872b
Author: Nobuto Murata <email address hidden>
Date: Fri Jan 19 17:31:30 2018 +0000

    OPENSTACK_KEYSTONE_MULTIDOMAIN_SUPPORT expects boolean

    Previously the single domain mode has been implemented. This is a
    follow-up commit to set the value properly as boolean instead of string.

    Change-Id: I0e34d93d05693bf0ca5e8f68bc9af198fd29680a
    Closes-Bug: #1744346
    Related-Bug: #1712999
    (cherry picked from commit 48119619a0df4445432bfcbcb0a5a0a585226774)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.