Error: Could not find resource 'Class[Pacemaker::Stonith]' for relationship from 'Class[Tripleo::Fencing]'

Bug #1712605 reported by Michele Baldessari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Michele Baldessari

Bug Description

Change Ifef08033043a4cc90a6261e962d2fdecdf275650 broke the stonith <-> fencing relation on non pacemaker_master nodes because the class[Pacemaker::Stonith] is not defined any longer.

Changed in tripleo:
assignee: nobody → Michele Baldessari (michele)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/496807

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/496807
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=17396dcea8c8597e20f19b1f5867cb67554133ce
Submitter: Jenkins
Branch: master

commit 17396dcea8c8597e20f19b1f5867cb67554133ce
Author: Michele Baldessari <email address hidden>
Date: Wed Aug 23 17:45:41 2017 +0200

    Use resource collector for the fencing -> stonith ordering

    Change Ifef08033043a4cc90a6261e962d2fdecdf275650 moved the stonith
    property definition to the pacemaker_master node. This means that the
    Class['tripleo::fencing'] -> Class['pacemaker::stonith'] ordering
    breaks on non-boostrap pacemaker nodes because the pacemaker::stonith
    property is not defined there any longer.

    Let's fix this by simply using a resource collector and set the ordering
    on that instead of adding yet anoth if statement. Ordering on
    enablement of stonith is actually more correct formally.

    Tested this on a broken setup successfully.

    Closes-Bug: #1712605
    Change-Id: I616d340bdf75da9d9eb8b83b2e804dff3d07d58e

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 7.3.0

This issue was fixed in the openstack/puppet-tripleo 7.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/497732

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/ocata)

Reviewed: https://review.openstack.org/497732
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=0694a3d07806b013895c01eb362dd0801c69bd9a
Submitter: Jenkins
Branch: stable/ocata

commit 0694a3d07806b013895c01eb362dd0801c69bd9a
Author: Michele Baldessari <email address hidden>
Date: Wed Aug 23 17:45:41 2017 +0200

    Use resource collector for the fencing -> stonith ordering

    Change Ifef08033043a4cc90a6261e962d2fdecdf275650 moved the stonith
    property definition to the pacemaker_master node. This means that the
    Class['tripleo::fencing'] -> Class['pacemaker::stonith'] ordering
    breaks on non-boostrap pacemaker nodes because the pacemaker::stonith
    property is not defined there any longer.

    Let's fix this by simply using a resource collector and set the ordering
    on that instead of adding yet anoth if statement. Ordering on
    enablement of stonith is actually more correct formally.

    Tested this on a broken setup successfully.

    Closes-Bug: #1712605
    Change-Id: I616d340bdf75da9d9eb8b83b2e804dff3d07d58e
    (cherry picked from commit 17396dcea8c8597e20f19b1f5867cb67554133ce)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 6.5.2

This issue was fixed in the openstack/puppet-tripleo 6.5.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.