Containerized overcloud with pacemaker is missing CI

[Jiří Stránský]

We should implement CI for containerized deployments with pacemaker, as that's the intended production scenario.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/495850

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/495850
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=c44fc11c569b25cc53d31942e07e4979dcc8bb4b
Submitter: Jenkins
Branch: master

commit c44fc11c569b25cc53d31942e07e4979dcc8bb4b
Author: Jiri Stransky <email address hidden>
Date: Mon Aug 21 14:51:29 2017 +0200

    Containerized deployment with pacemaker via OOOQ

    When deploying containerized and enable_pacemaker is set to true, make
    sure to include the docker-ha.yaml file.

    Also this cleans up the `when` conditional, which allows to remove the
    docker.yaml file from network_args, which prevents network_args from
    unwantedly overriding docker-ha.yaml contents from container_args.

    Change-Id: I5f28d2f784b9cd381ba370c9635300fe0ed79845
    Partial-Bug: #1712070

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/497485

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/497485
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=1a97e78f4713e70974be6f361a325cd2a224e762
Submitter: Jenkins
Branch: master

commit 1a97e78f4713e70974be6f361a325cd2a224e762
Author: Jiri Stransky <email address hidden>
Date: Thu Aug 24 18:32:41 2017 +0200

    Don't pass puppet-pacemaker.yaml to containerized HA envs

    This shouldn't change functionality, as container_args would override
    values from this env file when both containerized_overcloud and
    enable_pacemaker are set to true. However, we wouldn't be recommending
    users to deploy with both `-e puppet-pacemaker.yaml -e docker-ha.yaml`
    at the same time, so we shouldn't be passing it like that in OOOQ
    either.

    The change is from a patch by Wes [1], instead of which we merged a
    different patch in the end, but i believe we still need at least this
    part from it.

    [1] https://review.openstack.org/491146

    Change-Id: I9e0858b5cee8d14e69f218cd9957079787b92db8
    Co-Authored-By: Wesley Hayutin <email address hidden>
    Related-Bug: #1712070

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/498474

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/498474
Reason: I need to purge the gate because TripleO CI gate has critical issues right now, I'll make this patch goes to the gate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/498474
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5b805cb37eec3097552314c6ce43c02c2a604d81
Submitter: Jenkins
Branch: master

commit 5b805cb37eec3097552314c6ce43c02c2a604d81
Author: Jiri Stransky <email address hidden>
Date: Mon Aug 28 16:05:26 2017 +0200

    Add clustercheck to service list for scenarios

    This service is necessary when we containerized TripleO with
    Pacemaker.

    The service is added also to non-containerized scenario lists, because
    the aim is to get rid of the -containers.yaml variants eventually.
    This shouldn't affect any jobs that don't include docker-ha.yaml. The
    resource registry entry is mapped to OS::Heat::None by default, and
    docker-ha.yaml maps it to actual containerized clustercheck.

    Change-Id: I342e29de52cb6ce069a05a2dbfb0501a2da200e6
    Partial-Bug: #1712070

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/499133

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/499965

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/499966

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499965
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=80d89048f6c1c986bfa8c37a3e207321a3302121
Submitter: Jenkins
Branch: master

commit 80d89048f6c1c986bfa8c37a3e207321a3302121
Author: Giulio Fidente <email address hidden>
Date: Fri Sep 1 12:41:01 2017 +0200

    Enable pacemaker in scenario004/containers

    Change-Id: Iba97c0a6a4b4b0529c6434d58275a3d362b74947
    Related-Bug: #1712070

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499966
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=02cd34d148d6abf11cc64852f7931cbd4bccf767
Submitter: Jenkins
Branch: master

commit 02cd34d148d6abf11cc64852f7931cbd4bccf767
Author: Giulio Fidente <email address hidden>
Date: Fri Sep 1 12:42:40 2017 +0200

    Switch manila-share to pacemaker version in scenario004/containers

    Change-Id: Iefc0d04b19953ece60cf5c886258ed794e5c795d
    Depends-On: Iba97c0a6a4b4b0529c6434d58275a3d362b74947
    Related-Bug: #1712070

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/500314

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499133
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1fd5d9ea8b1c26a6a1aaea0427915459e55656ef
Submitter: Jenkins
Branch: stable/pike

commit 1fd5d9ea8b1c26a6a1aaea0427915459e55656ef
Author: Jiri Stransky <email address hidden>
Date: Mon Aug 28 16:05:26 2017 +0200

    Add clustercheck to service list for scenarios

    This service is necessary when we containerized TripleO with
    Pacemaker.

    The service is added also to non-containerized scenario lists, because
    the aim is to get rid of the -containers.yaml variants eventually.
    This shouldn't affect any jobs that don't include docker-ha.yaml. The
    resource registry entry is mapped to OS::Heat::None by default, and
    docker-ha.yaml maps it to actual containerized clustercheck.

    Change-Id: I342e29de52cb6ce069a05a2dbfb0501a2da200e6
    Partial-Bug: #1712070
    (cherry picked from commit 5b805cb37eec3097552314c6ce43c02c2a604d81)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/500314
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9f5a01447bf45fff2f34a255c9cf64957620dd60
Submitter: Jenkins
Branch: stable/pike

commit 9f5a01447bf45fff2f34a255c9cf64957620dd60
Author: Giulio Fidente <email address hidden>
Date: Fri Sep 1 12:42:40 2017 +0200

    Switch manila-share to pacemaker version in scenario004/containers

    Change-Id: Iefc0d04b19953ece60cf5c886258ed794e5c795d
    Depends-On: Iba97c0a6a4b4b0529c6434d58275a3d362b74947
    Related-Bug: #1712070
    (cherry picked from commit 02cd34d148d6abf11cc64852f7931cbd4bccf767)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jiri Stransky (<email address hidden>) on branch: master
Review: https://review.openstack.org/471724
Reason: Ack i'll abandon this one, and i think the way that follows the guideline of switching this on in scenarios rather than featuresets would be https://review.openstack.org/#/c/501872

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/507471

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/507623

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/507801

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507623
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b4d0a81e55ad51ecdaf2e923f794418ac77cfc57
Submitter: Jenkins
Branch: master

commit b4d0a81e55ad51ecdaf2e923f794418ac77cfc57
Author: Jiri Stransky <email address hidden>
Date: Tue Sep 26 18:31:59 2017 +0200

    Add all services to scenario004-containers

    This commit brings the scenario004 file closer to its BM pendant. We
    need to start with this one to address a chicken-and-egg issue with
    featureset files.

    Change-Id: Ia5c0cefb7051ca42b4d470f5a000eb446d18be30
    Co-Authored-By: Martin André <email address hidden>
    Related-Bug: #1714905
    Related-Bug: #1712070

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/507896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507801
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=31550b42027588d82f01db6956c1efaf02d58558
Submitter: Jenkins
Branch: master

commit 31550b42027588d82f01db6956c1efaf02d58558
Author: Jiri Stransky <email address hidden>
Date: Wed Sep 27 11:15:35 2017 +0200

    Stop mapping docker to OS::Heat::None in scenarios

    This was needed to make the upgrade job on Ocata->Pike passing, and we
    now need to remove this to improve the argument order in OOOQ for
    deployments with scenarios.

    This shouldn't be backported to Ocata (at least not before we make the
    split between deploy scenario and upgrade scenario).

    Change-Id: Ie08bbe08530bd48a0ca58667f0704f360e0a4dd7
    Co-Authored-By: Martin André <email address hidden>
    Related-Bug: #1714905
    Related-Bug: #1712070

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/507907

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507896
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=72e5ec2a136bed7db610be2cb9af7fb510d536f8
Submitter: Jenkins
Branch: stable/pike

commit 72e5ec2a136bed7db610be2cb9af7fb510d536f8
Author: Jiri Stransky <email address hidden>
Date: Tue Sep 26 18:31:59 2017 +0200

    Add all services to scenario004-containers

    This commit brings the scenario004 file closer to its BM pendant. We
    need to start with this one to address a chicken-and-egg issue with
    featureset files.

    Change-Id: Ia5c0cefb7051ca42b4d470f5a000eb446d18be30
    Co-Authored-By: Martin André <email address hidden>
    Related-Bug: #1714905
    Related-Bug: #1712070
    (cherry picked from commit b4d0a81e55ad51ecdaf2e923f794418ac77cfc57)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507907
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=682686e66b379ab5a04b5cc0752048fb6d2e5100
Submitter: Jenkins
Branch: stable/pike

commit 682686e66b379ab5a04b5cc0752048fb6d2e5100
Author: Jiri Stransky <email address hidden>
Date: Wed Sep 27 11:15:35 2017 +0200

    Stop mapping docker to OS::Heat::None in scenarios

    This was needed to make the upgrade job on Ocata->Pike passing, and we
    now need to remove this to improve the argument order in OOOQ for
    deployments with scenarios.

    This shouldn't be backported to Ocata (at least not before we make the
    split between deploy scenario and upgrade scenario).

    Change-Id: Ie08bbe08530bd48a0ca58667f0704f360e0a4dd7
    Co-Authored-By: Martin André <email address hidden>
    Related-Bug: #1714905
    Related-Bug: #1712070
    (cherry picked from commit 31550b42027588d82f01db6956c1efaf02d58558)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Martin André (<email address hidden>) on branch: master
Review: https://review.openstack.org/507471
Reason: Squashed with Icb659509b38575534be27a1881dbe671c40a5436 as they both depend on Ie0e8de54794a9259c0aeb8c67ae0f6a908844093 and there is no good reason to have separate commits.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501872
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c504f83c28b986ceb2b92cc0077959158bd11df7
Submitter: Zuul
Branch: master

commit c504f83c28b986ceb2b92cc0077959158bd11df7
Author: Martin André <email address hidden>
Date: Thu Sep 7 22:50:49 2017 +0200

    Add all services to container scenarios

    This commit brings the multinode containers scenario files closer to
    their BM variants to add missing services and turning pacemaker on.
    These require refactorings in OOOQ in order to support non-containerized
    to containerized upgrade jobs across releases. Ceph-ansible is also
    going to be switched separately.

    Co-Authored-By: Jiri Stransky <email address hidden>
    Depends-On: Ie0e8de54794a9259c0aeb8c67ae0f6a908844093
    Change-Id: Icb659509b38575534be27a1881dbe671c40a5436
    Related-Bug: #1714905
    Related-Bug: #1712070

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/512305

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/512320

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jiri Stransky (<email address hidden>) on branch: master
Review: https://review.openstack.org/512320

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/512305
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c1e7ff180e31f53b198ecc21dd970eee153a9972
Submitter: Zuul
Branch: stable/pike

commit c1e7ff180e31f53b198ecc21dd970eee153a9972
Author: Martin André <email address hidden>
Date: Thu Sep 7 22:50:49 2017 +0200

    Add all services to container scenarios

    This commit brings the multinode containers scenario files closer to
    their BM variants to add missing services and turning pacemaker on.
    These require refactorings in OOOQ in order to support non-containerized
    to containerized upgrade jobs across releases. Ceph-ansible is also
    going to be switched separately.

    Co-Authored-By: Jiri Stransky <email address hidden>
    Depends-On: Ie0e8de54794a9259c0aeb8c67ae0f6a908844093
    Change-Id: Icb659509b38575534be27a1881dbe671c40a5436
    Related-Bug: #1714905
    Related-Bug: #1712070
    (cherry picked from commit c504f83c28b986ceb2b92cc0077959158bd11df7)

[Alex Schultz (alex-schultz)]

OVB has been switched to containers so this should be covered now. Closing for now, feel free to reopen if needed.