KeyError: 'bmc_prefix' ovb version in oooq is no longer working

[wes hayutin]

openstack-virtual-baremetal/bin/build-nodes-json --env 850-whayutin--env.yaml
Traceback (most recent call last):
  File "openstack-virtual-baremetal/bin/build-nodes-json", line 218, in <module>
    main()
  File "openstack-virtual-baremetal/bin/build-nodes-json", line 205, in main
    bmc_base, baremetal_base, provision_net, undercloud_name = _get_names(args)
  File "openstack-virtual-baremetal/bin/build-nodes-json", line 75, in _get_names
    bmc_base = e['parameter_defaults']['bmc_prefix']
KeyError: 'bmc_prefix'

[wes hayutin (weshayutin)]

TASK [ovb-manage-stack : Build nodes.json file to be used as instackenv.json] **
task path: /var/tmp/devmode/usr/local/share/ansible/roles/ovb-manage-stack/tasks/ovb-create-stack.yml:134
Thursday 10 August 2017 15:02:12 -0400 (0:02:23.547) 0:05:29.829 *******
fatal: [localhost]: FAILED! => {"changed": true, "cmd": "export OS_CLIENT_CONFIG_FILE=\"/var/tmp/devmode/clouds.yaml\"; export OS_CLOUD=\"rdocloud\"; /var/tmp/devmode/openstack-virtual-baremetal/bin/build-nodes-json --env /var/tmp/devmode/850-whayutin--env.yaml", "delta": "0:00:00.601975", "end": "2017-08-10 15:02:13.242940", "failed": true, "rc": 1, "start": "2017-08-10 15:02:12.640965", "stderr": "Traceback (most recent call last):\n File \"/var/tmp/devmode/openstack-virtual-baremetal/bin/build-nodes-json\", line 218, in <module>\n main()\n File \"/var/tmp/devmode/openstack-virtual-baremetal/bin/build-nodes-json\", line 205, in main\n bmc_base, baremetal_base, provision_net, undercloud_name = _get_names(args)\n File \"/var/tmp/devmode/openstack-virtual-baremetal/bin/build-nodes-json\", line 75, in _get_names\n bmc_base = e['parameter_defaults']['bmc_prefix']\nKeyError: 'bmc_prefix'", "stdout": "", "stdout_lines": [], "warnings": []}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/492686

[Ben Nemec (bnemec)]

Oh, damn. I missed this case in my backwards compatibility testing (and old-style environment without using --id to deploy). I'll get it fixed shortly.

[Ben Nemec (bnemec)]

Should be working again: https://github.com/cybertron/openstack-virtual-baremetal/commit/4804ae064def8c5bc2bd272cf96de25d73bd8f13

Will add some more unit tests to make sure I don't break this again.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/492686
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=4cf4dfdadf4bf675df339bd93095fc3b2d878891
Submitter: Jenkins
Branch: master

commit 4cf4dfdadf4bf675df339bd93095fc3b2d878891
Author: Wes Hayutin <email address hidden>
Date: Thu Aug 10 17:02:01 2017 -0400

    pin the ovb git repo to a working version

    Closes-Bug: #1710013
    Change-Id: I9fc7e86ffb53727b733af29a1ca4562f10f41afc

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.