Web Staff Client: Reports description field required

[Terran McCanna]

Tested as of 2.12.2

When creating a new report template, I cannot save it without entering something into the description field. I don't see why that would be a required field.

[Mike Rylander (mrylander)]

The description field on reporter.template has actually always been marked NOT NULL. IIRC, the intention was to strongly encourage staff to enter a meaningful description of the report, and (also IIRC) the decision on that didn't come from the developers.

There are several ways we could address this: make the field NULLABLE in the database; default it to and empty string instead of undefined in the UI; mark it as required and have the form complain and refuse to submit (which would address any post-save failure caused by this requirement, if that's possible today -- I don't recall).

Are there broader thoughts from the community?

[Kathy Lussier (klussier)]

In the xul client, we are able to save a template without adding a description. Is this because the xul client was defaulting to an empty string in that field?

Mike, currently I think the web client is behaving as you described in the 2nd option. The save button is disabled until something is entered in the description field.

We almost always include a description in our templates, but I don't see a reason why we should force that on a user.

A mild +1 to defaulting to either making the field NULLABLE or defaulting to an empty string.

[Rogan Hamby (rogan-hamby)]

HEAD:user/rogan/lp1709698_template_description_should_be_nullable

[Rogan Hamby (rogan-hamby)]

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=cf982a7931c52f4502d281af1f602fa60a1dd8eb

[Rogan Hamby (rogan-hamby)]

Removing pullrequest. Some issues were found that need to be addressed in how the information ends up passing to the report interface.

[Rogan Hamby (rogan-hamby)]

New patch.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=4fca8af02633022f659a0d9819d9302f8a73d1cf

[Jessica Woolford (jwoolford)]

I have tested this code and consent to signing off with my name, Jessica Woolford, and email address, <email address hidden>.

[Chris Sharp (chrissharp123)]

Committed to master. Thanks, Rogan and Jessica!

[Remington Steed (rjs7)]

I fixed the milestone and status for this bug, which was released in 3.3.0. Thanks to Michele Morgan for the clue (via her comment on bug 1780639).