OsNetConfigMappings should be case insensitive in os-net-config-mappings.yaml

Bug #1709653 reported by Andreas Karis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Andreas Karis

Bug Description

OsNetConfigMappings should be case insensitive in os-net-config-mappings.yaml

Currently, if a user adds e.g.:
nic1: "00:C8:7C:E6:F0:2E"

The above will fail and not map at all. This should be transparent to the user, he/she should be able to use both upper or lower case.

Andreas Karis (akaris)
Changed in tripleo:
assignee: nobody → Andreas Karis (akaris)
Revision history for this message
Andreas Karis (akaris) wrote :

  NetConfigDataLookup:
    node1:
      nic1: '52:54:00:BF:53:80'
      nic2: '52:54:00:0C:0A:BF'
      nic3: '52:54:00:F4:1D:C8'
      nic4: '52:54:00:D5:C3:9E'
      nic5: '52:54:00:51:FB:8E'
    node2:
      nic1: '52:54:00:9B:7B:09'
      nic2: '52:54:00:ED:00:57'
      nic3: '52:54:00:33:DE:4B'
      nic4: '52:54:00:D2:45:8F'
      nic5: '52:54:00:0D:28:64'
    node3:
      nic1: '52:54:00:AD:E3:3E'
      nic2: '52:54:00:DB:37:89'
      nic3: '52:54:00:19:E4:6B'
      nic4: '52:54:00:24:AC:4A'
      nic5: '52:54:00:81:1E:80'
    node4:
      nic1: '52:54:00:65:82:BE'
      nic2: '52:54:00:16:57:AA'
      nic3: '52:54:00:A2:6E:06'
      nic4: '52:54:00:65:4F:97'
      nic5: '52:54:00:E0:17:44'
    node5:
      nic1: '52:54:00:CF:AC:2F'
      nic2: '52:54:00:F7:5F:FB'
      nic3: '52:54:00:41:B6:72'
      nic4: '52:54:00:B2:EA:B9'
      nic5: '52:54:00:33:ED:CE'

should yield:

[root@overcloud-controller-0 ~]# cat /etc/os-net-config/mapping.yaml
interface_mapping:
  nic1: 52:54:00:ad:e3:3e
  nic2: 52:54:00:db:37:89
  nic3: 52:54:00:19:e4:6b
  nic4: 52:54:00:24:ac:4a
  nic5: 52:54:00:81:1e:80

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/492244

Changed in tripleo:
status: New → In Progress
Changed in tripleo:
milestone: none → pike-rc1
importance: Undecided → Medium
milestone: pike-rc1 → queens-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/492244
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=397a5cc207cf69778d80391f2865619d525b2368
Submitter: Jenkins
Branch: master

commit 397a5cc207cf69778d80391f2865619d525b2368
Author: Andreas Karis <email address hidden>
Date: Wed Aug 9 16:07:40 2017 -0400

    Case insentitive MAC address matching in OsNetConfigMappings

    OsNetConfigMappings should be case insensitive in
    os-net-config-mappings.yaml
    This patch casts all MAC addresses to lower case.

    Change-Id: Ide18660a3a8063cfdf53500cd727c8f49407b436
    Closes-Bug: 1709653

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.0.0b1

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/529646

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/529649

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/529650

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/ocata)

Reviewed: https://review.openstack.org/529649
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=60d147b51bf59a533ac4370fd9ed270e550cfc34
Submitter: Zuul
Branch: stable/ocata

commit 60d147b51bf59a533ac4370fd9ed270e550cfc34
Author: Andreas Karis <email address hidden>
Date: Wed Aug 9 16:07:40 2017 -0400

    Case insentitive MAC address matching in OsNetConfigMappings

    OsNetConfigMappings should be case insensitive in
    os-net-config-mappings.yaml
    This patch casts all MAC addresses to lower case.

    Change-Id: Ide18660a3a8063cfdf53500cd727c8f49407b436
    Closes-Bug: 1709653
    (cherry picked from commit 397a5cc207cf69778d80391f2865619d525b2368)

tags: added: in-stable-ocata
tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/newton)

Reviewed: https://review.openstack.org/529650
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f62da2870adb71226fedb9c43ebc4176dccd5bd4
Submitter: Zuul
Branch: stable/newton

commit f62da2870adb71226fedb9c43ebc4176dccd5bd4
Author: Andreas Karis <email address hidden>
Date: Wed Aug 9 16:07:40 2017 -0400

    Case insentitive MAC address matching in OsNetConfigMappings

    OsNetConfigMappings should be case insensitive in
    os-net-config-mappings.yaml
    This patch casts all MAC addresses to lower case.

    Change-Id: Ide18660a3a8063cfdf53500cd727c8f49407b436
    Closes-Bug: 1709653
    (cherry picked from commit 397a5cc207cf69778d80391f2865619d525b2368)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/529646
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=768250b59b01594d1072cc63a1215e1c2fc31a46
Submitter: Zuul
Branch: stable/pike

commit 768250b59b01594d1072cc63a1215e1c2fc31a46
Author: Andreas Karis <email address hidden>
Date: Wed Aug 9 16:07:40 2017 -0400

    Case insentitive MAC address matching in OsNetConfigMappings

    OsNetConfigMappings should be case insensitive in
    os-net-config-mappings.yaml
    This patch casts all MAC addresses to lower case.

    Change-Id: Ide18660a3a8063cfdf53500cd727c8f49407b436
    Closes-Bug: 1709653
    (cherry picked from commit 397a5cc207cf69778d80391f2865619d525b2368)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 6.2.8

This issue was fixed in the openstack/tripleo-heat-templates 6.2.8 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 5.3.8

This issue was fixed in the openstack/tripleo-heat-templates 5.3.8 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 7.0.7

This issue was fixed in the openstack/tripleo-heat-templates 7.0.7 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.