Quotas not honored per-tenant

[Thomas Bachman]

The following issue was reported:

"In the Newton AIM code base, when loading the service_plugins = apic_aim_l3, we noticed its loading the old quota driver (neutron.quota.ConfDriver) instead of default neutron.db.quota.driver.DbQuotaDriver

This prevents us from increasing quotas on a per tenant basis, we can change quotas globally through neutron.conf but a quota update with neutron quota-update doesn’t get honored.

Here is the debug message

2017-08-01 14:53:57.834 308585 INFO neutron.quota [-] ConfDriver is used as quota_driver because the loaded plugin does not support 'quotas' table.
2017-08-01 14:53:57.835 308585 WARNING neutron.quota [-] Deprecated: The quota driver neutron.quota.ConfDriver is deprecated as of Liberty. neutron.db.quota.driver.DbQuotaDriver should be used in its place
2017-08-01 14:53:57.835 308585 INFO neutron.quota [-] Loaded quota_driver: <neutron.quota.ConfDriver object at 0x3c82ad0>."

We need to add support for quotas to our plugin(s). This web page outlines support for the quotas framework:

https://docs.openstack.org/neutron/mitaka/devref/quota.html

In short, plugins are supposed to support the quotas extension driver, and are supposed to add decorators in their init methods to call out the resources that they support tracking for. This patch in upstream neutron added the decorator to the reference implementation L3 plugin:

openstack/neutron@0d7b539#diff-e6ae0f3896f9c7fd927f93cb8bb52174

We'll need to figure out our resource tracking implementation and add the appropriate support.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/491894
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=194dd33947f1939ab9e1976ccc465c1878086bcf
Submitter: Jenkins
Branch: master

commit 194dd33947f1939ab9e1976ccc465c1878086bcf
Author: Thomas Bachman <email address hidden>
Date: Tue Aug 8 18:49:25 2017 +0000

    Fix per-project quotas for L3 plugin

    The GBP L3 plugin is using the old quotas driver. This prevents
    per-project quotas for L3 resources. The L3 plugin should be
    changed to support the new qutoas driver.

    Change-Id: Idbc651a905ca5c567527ba2094a83b2d0486ca9a
    Closes-Bug: 1709456

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/498896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/498896
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=41152b4fde6c6a5785e8d97b30dee4408898bb57
Submitter: Jenkins
Branch: stable/ocata

commit 41152b4fde6c6a5785e8d97b30dee4408898bb57
Author: Thomas Bachman <email address hidden>
Date: Tue Aug 8 18:49:25 2017 +0000

    Fix per-project quotas for L3 plugin

    The GBP L3 plugin is using the old quotas driver. This prevents
    per-project quotas for L3 resources. The L3 plugin should be
    changed to support the new qutoas driver.

    Change-Id: Idbc651a905ca5c567527ba2094a83b2d0486ca9a
    Closes-Bug: 1709456
    (cherry picked from commit 194dd33947f1939ab9e1976ccc465c1878086bcf)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/499190

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499190
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=c5a45bd3ce0ba1647ffaf9e702d4fc9e6308a2f3
Submitter: Jenkins
Branch: stable/newton

commit c5a45bd3ce0ba1647ffaf9e702d4fc9e6308a2f3
Author: Thomas Bachman <email address hidden>
Date: Tue Aug 8 18:49:25 2017 +0000

    Fix per-project quotas for L3 plugin

    The GBP L3 plugin is using the old quotas driver. This prevents
    per-project quotas for L3 resources. The L3 plugin should be
    changed to support the new qutoas driver.

    Change-Id: Idbc651a905ca5c567527ba2094a83b2d0486ca9a
    Closes-Bug: 1709456
    (cherry picked from commit 194dd33947f1939ab9e1976ccc465c1878086bcf)
    (cherry picked from commit 41152b4fde6c6a5785e8d97b30dee4408898bb57)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/499622

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499622
Committed: https://git.openstack.org/cgit/openstack/group-based-policy/commit/?id=1fb474945e963d38d040f2f3c6ac9807f7e16338
Submitter: Jenkins
Branch: stable/mitaka

commit 1fb474945e963d38d040f2f3c6ac9807f7e16338
Author: Thomas Bachman <email address hidden>
Date: Tue Aug 8 18:49:25 2017 +0000

    Fix per-project quotas for L3 plugin

    The GBP L3 plugin is using the old quotas driver. This prevents
    per-project quotas for L3 resources. The L3 plugin should be
    changed to support the new qutoas driver.

    Change-Id: Idbc651a905ca5c567527ba2094a83b2d0486ca9a
    Closes-Bug: 1709456
    (cherry picked from commit 194dd33947f1939ab9e1976ccc465c1878086bcf)
    (cherry picked from commit 41152b4fde6c6a5785e8d97b30dee4408898bb57)
    (cherry picked from commit c5a45bd3ce0ba1647ffaf9e702d4fc9e6308a2f3)