port security payload sent to agents changed after push notifications

[Jakub Libosvar]

Agent call to get_device_info for security groups changed the payload format. Specifically port_security_enabled is now not part of port dict but under 'security'. So when firewalls check for port security [1] they always get True cause they access port['port_security_enabled'] instead of port['security']['port_security_enabled'].

[1] https://github.com/openstack/neutron/blob/master/neutron/agent/firewall.py#L49

[YaZug (jon-schlueter)]

tripleo-ci is seeing this failure

http://logs.openstack.org/15/491415/1/check/gate-tripleo-ci-centos-7-scenario001-multinode-oooq/1c4c797/logs/tempest.html.gz

[YaZug (jon-schlueter)]

test_port_security_macspoofing_port[compute,id-7c0bb1a2-d053-49a4-98f9-ca1a1d849f63,network,slow] - this is the tempest test that is failing

[wes hayutin (weshayutin)]

This is a dupe lp, https://bugs.launchpad.net/tripleo/+bug/1605654 is the original

[YaZug (jon-schlueter)]

this is the candidate for regression: https://review.openstack.org/#/c/410422/