undercloud deploy double kills heat_all container

[James Slagle]

the undercloud deploy double kills the heat_all container because both the parent process and the forked child process that started the container try and kill the heat_all container.

This results in some error messages at the end of the deploy that are otherwise harmless, but make one think there might be something wrong:

Deploy Successful.
Log files at: /tmp/undercloud_deploy-gjZEC8
Unable to establish connection to http://127.0.0.1:8006/v1/admin/stacks/undercloud/90b6b887-23b4-4ed8-b7c4-f9425f884d02/events?marker=f3fd6ae3-0fd4-4829-b384-6efe623d6ac9&nested_depth=6&sort_dir=asc:
('Connection aborted.', BadStatusLine("''",))
Log files at: /tmp/undercloud_deploy-gjZEC8
heat_all
Command '['docker', 'run', '--name', 'heat_all', '--user', 'heat', '--net',
'host', '--volume',
'/tmp/undercloud_deploy-gjZEC8/heat.conf:/etc/heat/heat.conf', '--volume',
'/tmp/undercloud_deploy-gjZEC8:/tmp/undercloud_deploy-gjZEC8:rw', '--volume', '/usr/lib/python2.7/site-packages/tripleoclient/noauth_policy.json:/usr/lib/python2.7/site-packages/tripleoclient/noauth_policy.json:ro',
'tripleoupstream/centos-binary-heat-all', 'heat-all']' returned non-zero exit
status 137
heat_all

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/491787

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/491787
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=b6693c12554cb2511023e858d4418ffe74d411dd
Submitter: Zuul
Branch: master

commit b6693c12554cb2511023e858d4418ffe74d411dd
Author: James Slagle <email address hidden>
Date: Tue Aug 8 08:51:23 2017 -0400

    Don't doube kill heat_all

    The heat_all process (either the container or native) was being killed
    twice. Once by the parent process and once by the same child process
    that spawned it.

    Checking that heat_pid != 0 before killing the process will ensure only
    the parent process will kill the heat_all process.

    Change-Id: I677b6a633b028341cb157ce5fb1b1855da7dead8
    Closes-Bug: #1709311

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 8.0.0 release.