git ubuntu lint: linting a local branch requires passing --lint-namespace=
Bug #1709154 reported by
Nish Aravamudan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| git-ubuntu |
Fix Released
|
Undecided
|
Nish Aravamudan | ||
Bug Description
Because the code is written to be called from `git ubuntu review`, it assumes all branches are remote (and thus in <remote>/). That's not true when doing local development. We should figure this out better (e.g., if there is no user branch locally, or if it hasn't been pushed anywhere), just default to no namespace.
Related branches
~nacc/git-ubuntu:bug-fixes-2
- Robie Basak: Approve
-
Diff: 1648 lines (+758/-328)16 files modifiedgitubuntu/__main__.py (+4/-1)
gitubuntu/clone.py (+8/-5)
gitubuntu/git_repository.py (+398/-225)
gitubuntu/importer.py (+32/-12)
gitubuntu/importppa.py (+8/-2)
gitubuntu/lint.py (+210/-54)
gitubuntu/merge.py (+13/-5)
gitubuntu/queue.py (+12/-2)
gitubuntu/remote.py (+9/-2)
gitubuntu/run.py (+12/-9)
gitubuntu/submit.py (+10/-9)
gitubuntu/versioning.py (+2/-2)
snap/snapcraft.yaml (+1/-0)
tests/changelogs/test_versions_1 (+5/-0)
tests/changelogs/test_versions_2 (+11/-0)
tests/changelogs/test_versions_3 (+23/-0)
| Changed in usd-importer: | |
| milestone: | none → 1.0 |
| status: | New → Confirmed |
| assignee: | nobody → Nish Aravamudan (nacc) |
| Changed in usd-importer: | |
| status: | Confirmed → In Progress |
| Changed in usd-importer: | |
| status: | In Progress → Won't Fix |
| status: | Won't Fix → Fix Released |
To post a comment you must log in.
