split-stack minor update does not prompt to clear breakpoints

[James Slagle]

When doing a minor update:

openstack overcloud update stack -i overcloud

with split-stack using pre-provisioned nodes, you are never prompted to clear any breakpoints. The client finishes running but the Heat stack is still stuck in progress until breakpoints are cleared.

This is due to the code in tripleo-common querying nova for server names and id's, but there are no nova servers when using pre-provisioned nodes. In that case, we will have to query Heat directly for the names and id's.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/490125

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/490125
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=39c8616876267644052c457eb3b7af4219a0a09c
Submitter: Jenkins
Branch: master

commit 39c8616876267644052c457eb3b7af4219a0a09c
Author: James Slagle <email address hidden>
Date: Wed Aug 2 14:15:00 2017 -0400

    Prompt to clear breakpoints when using deployed-server

    On a minor interactive update, we never prompoted to clear breakpoints
    when using deployed-server since the code reads the server id's from
    nova, of which there are none.

    This modifies the behavior to read the server id's and names from Heat
    when nova returns no servers.

    Change-Id: I682f6dc66705c9d42b9c2d21f675491ea60c9c3c
    Closes-Bug: #1708236

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/491115

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/491115
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=6a939cb99414609940d4076223faa77537c09e4a
Submitter: Jenkins
Branch: stable/ocata

commit 6a939cb99414609940d4076223faa77537c09e4a
Author: James Slagle <email address hidden>
Date: Wed Aug 2 14:15:00 2017 -0400

    Prompt to clear breakpoints when using deployed-server

    On a minor interactive update, we never prompoted to clear breakpoints
    when using deployed-server since the code reads the server id's from
    nova, of which there are none.

    This modifies the behavior to read the server id's and names from Heat
    when nova returns no servers.

    Change-Id: I682f6dc66705c9d42b9c2d21f675491ea60c9c3c
    Closes-Bug: #1708236
    (cherry picked from commit 39c8616876267644052c457eb3b7af4219a0a09c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 7.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 6.1.1 release.