puppet-tripleo unit jobs failing for tripleo::profile::base::nova::libvirt

[Alex Schultz]

http://logs.openstack.org/75/486575/5/check/gate-puppet-tripleo-puppet-unit-4.5-centos-7/ea39ed2/console.html#_2017-07-27_15_29_58_731740

Error seems to point to missing step data in the tests and duplicate declarations

2017-07-27 15:29:58.731832 | 1) tripleo::profile::base::nova::compute::libvirt on centos-7-x86_64 behaves like tripleo::profile::base::nova::compute::libvirt with step less than 4 should contain Class[tripleo::profile::base::nova::compute::libvirt]
2017-07-27 15:29:58.731958 | Failure/Error: is_expected.to contain_class('tripleo::profile::base::nova::compute::libvirt')
2017-07-27 15:29:58.731971 |
2017-07-27 15:29:58.731988 | Puppet::PreformattedError:
2017-07-27 15:29:58.732139 | Evaluation Error: Error while evaluating a Function Call, Could not find data item step in any Hiera data file and no default supplied at /home/jenkins/workspace/gate-puppet-tripleo-puppet-unit-4.5-centos-7/spec/fixtures/modules/tripleo/manifests/profile/base/nova/compute_libvirt_shared.pp:27:19 on node centos-7-ovh-gra1-10119559
2017-07-27 15:29:58.732200 | Shared Example Group: "tripleo::profile::base::nova::compute::libvirt" called from ./spec/classes/tripleo_profile_base_nova_compute_libvirt_spec.rb:72

2017-07-27 15:29:58.786101 | 8) tripleo::profile::base::nova::libvirt on redhat-7-x86_64 behaves like tripleo::profile::base::nova::libvirt with step 4 should contain Class[tripleo::profile::base::nova::libvirt]
2017-07-27 15:29:58.786172 | Failure/Error: is_expected.to contain_class('tripleo::profile::base::nova::libvirt')
2017-07-27 15:29:58.786186 |
2017-07-27 15:29:58.786218 | Puppet::PreformattedError:
2017-07-27 15:29:58.786501 | Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Class[Nova::Compute::Libvirt::Services] is already declared; cannot redeclare at /home/jenkins/workspace/gate-puppet-tripleo-puppet-unit-4.5-centos-7/spec/fixtures/modules/nova/manifests/compute/libvirt.pp:197 at /home/jenkins/workspace/gate-puppet-tripleo-puppet-unit-4.5-centos-7/spec/fixtures/modules/nova/manifests/compute/libvirt.pp:197:5 on node centos-7-ovh-gra1-10119559

[Alex Schultz (alex-schultz)]

https://review.openstack.org/#/c/485207 is where these failures came from but it's unclear why this was not picked up in CI

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/487976

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/487976
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=237e613a175fd975bf6679646eaf092ff6725015
Submitter: Jenkins
Branch: master

commit 237e613a175fd975bf6679646eaf092ff6725015
Author: Alex Schultz <email address hidden>
Date: Thu Jul 27 12:54:30 2017 -0600

    Fix nova and selinux unit tests

    The unit tests jobs are failing because of missing pre conditions for
    the new shared class introduced by
    Ib233689fdcdda391596d01a21f77bd8e1672ae04. Additionally this change
    moved some classes around so that the tests are now failing due to
    duplicate class declarations for nova::compute::libvirt::services. This
    change moves the include that pulls in the declaration first prior to
    the include that exists in tripleo::profile::base::nova::libvirt.

    The selinux test was also failing due to a type issue with the fact
    being used (boolean vs string)

    Change-Id: I5bd4b61d6008820729d58f7743e7e61955dd6f51
    Closes-Bug: #1707034

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.3.0 release.