Ambiguous docs/logging for --safe-slave-backup
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Percona XtraBackup moved to https://jira.percona.com/projects/PXB | Status tracked in 2.4 | |||||
2.3 |
Triaged
|
Wishlist
|
Sergei Glushchenko | |||
2.4 |
Triaged
|
Wishlist
|
Sergei Glushchenko |
Bug Description
https:/
"""
this option stops the slave SQL thread and wait to start backing up
"""
Testing (2.3.8) shows that the backup begins before replication is stopped - instead replication is stopped before issuing FTWRL (or backup/ddl/binlog locks)
Further, it does not seem to be logged when replication is stopped, only when started (without timestamp):
170726 20:42:10 Slave open temp tables: 0
170726 20:42:10 Slave is safe to backup
170726 20:42:10 Executing FLUSH NO_WRITE_TO_BINLOG TABLES...
170726 20:42:10 Executing FLUSH TABLES WITH READ LOCK...
170726 20:42:10 Starting to backup non-InnoDB tables and files
<SNIP>
170726 20:42:19 Executing UNLOCK TABLES
170726 20:42:19 All tables unlocked
Starting slave SQL thread
Changed in percona-xtrabackup: | |
assignee: | nobody → Muhammad Irfan (muhammad-irfan) |
Example desired logging output:
170726 20:42:10 Stopping slave SQL thread
170726 20:42:10 Slave open temp tables: 1
170726 20:42:10 Starting slave SQL thread
170726 20:42:10 Stopping slave SQL thread
170726 20:42:10 Slave open temp tables: 0
170726 20:42:10 Slave is safe to backup
<SNIP>
170726 20:42:18 [00] Streaming xtrabackup_ slave_info
170726 20:42:18 Starting slave SQL thread
As far as docs, it would be nice if it was more clear that replication is not stopped for the duration of the backup (while streaming ibd files)