refactor resource commands

Bug #1706809 reported by Anastasia
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
Medium
Anastasia

Bug Description

Resources commands - 'juju charm resources", "juju resources", "juju attach" - need to be moved from resources/cmd under a common infrastructure in cmd package.

They are also under-tested. We need to add unit tests to exercise them.

Tags: tech-debt
Revision history for this message
Anastasia (anastasia-macmood) wrote :

This is not a small piece of work.

I have broken it into several parts to facilitate and expedite reviews:

1. straightforward move of resource/cmd into cmd/juju/resource;
2. breakout from component registration;
3. resource listener should use accessor function internal similar to store;
4. sanity feature testing for full-stack connectivity.

Part 1 against develop: https://github.com/juju/juju/pull/7680

Revision history for this message
Anastasia (anastasia-macmood) wrote :

After some thought and consideration, part 3 is slightly different - resource lister is passed into constructor instead. PR against develop (2.3-alpha1): https://github.com/juju/juju/pull/7682

Revision history for this message
Anastasia (anastasia-macmood) wrote :

Part 2 of the fix against develop (2.3-alpha1): https://github.com/juju/juju/pull/7686

Revision history for this message
Anastasia (anastasia-macmood) wrote :

Final part, with the actual feature test, against develop (2.3-alpha1): https://github.com/juju/juju/pull/7691

Changed in juju:
status: Triaged → In Progress
Changed in juju:
status: In Progress → Fix Committed
milestone: none → 2.3-alpha1
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.