Opt-in action triggers display in patron editor when disabled

[Michele Morgan]

Evergreen 2.12.2

When opt-in action triggers are disabled, they do not appear in Notification Preferences when a patron is logged into the catalog. They do, however, appear in the patron editor in both the xul client and the web client.

This could lead to staff members setting notification preferences for patrons that will never run. The notification preferences in the patron editor should be consistent with what is displayed to the patron.

A workaround for removing disabled opt-in triggers from the patron editors is to set the action_trigger.opt_in_setting to NULL, but this is not ideal since it will be necessary to reset the opt_in_setting as well as checking of the flag to enable it for it to function.