web client: include inactive option in patron search is not sticky

[Kathy Lussier]

The xul client remembers the state of 'include inactive' checkbox in patron search. In the web client, when loading patron search, the checkbox is always unselected by default. This checkbox should remember its state on last use and either be selected/deselected based on that state.

In many libraries, circulation staff are always expected to include inactive patrons in their search before creating a new account. It's a step that will be easy to miss if the option is not selected as soon as the patron search screen loads.

[Terran McCanna (tmccanna)]

This will be a big problem for PINES.

[Kathy Lussier (klussier)]

I re-used the code Cesar did for bug 1697754 to make the 'include inactive' checkbox sticky. Thanks for leading the way Cesar!

Working branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1706124-sticky-include-inactive-patrons-checkbox

[Jason Stephenson (jstephenson)]

The branch applies to master/3.0 cleanly and works.

It does not apply to 2.12, as the files it modifies do not exist there. I'm inclined to push the branch to master and set the status of this bug for 2.12 to won't fix.

In the meantime, I've added a signoff pending discussion:

user/dyrcona/lp1706124-sticky-include-inactive-patrons-checkbox-signoff

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1706124-sticky-include-inactive-patrons-checkbox-signoff

[Terran McCanna (tmccanna)]

Thank you, Jason! +1 to just resolving it for 3.0

[Galen Charlton (gmc)]

Pushed to master, along with a follow-up that tweaks the name of the key to better match local conventions and adjust whitespace. Thanks, Kathy and Jason!

I don't mind this being only a 3.0 thing, but I won't touch the 2.12 targeting for tonight.

[Kathy Lussier (klussier)]

I hadn't looked at the 2.12 branch. Oh well. It would have been a nice fix for 2.12, but we can wait for 3.0. I'll remove the target for 2.12.