Junk in MM-SERVICE-PROVIDER leads to server-side error instead of client-side error

Bug #1705773 reported by Jeremy Freudberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mix and Match (mixmatch)
Fix Released
Undecided
Jeremy Freudberg

Bug Description

To reproduce: curl -H "MM-SERVICE-PROVIDER: fake" http://host:5001/image/v2/images

(on an installation without an sp called "fake")

We eventually end up with "NoSuchOptError: no such option sp_fake in group [DEFAULT]" because we do not fail early/gracefully.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mixmatch (master)

Fix proposed to branch: master
Review: https://review.openstack.org/486216

Changed in mixmatch:
assignee: nobody → Jeremy Freudberg (jfreud)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mixmatch (master)

Reviewed: https://review.openstack.org/486216
Committed: https://git.openstack.org/cgit/openstack/mixmatch/commit/?id=c1815c66ffc4501cb09d1a493ce4f955d1f094e7
Submitter: Jenkins
Branch: master

commit c1815c66ffc4501cb09d1a493ce4f955d1f094e7
Author: Jeremy Freudberg <email address hidden>
Date: Fri Jul 21 20:17:24 2017 +0000

    Catch invalid MM-SERVICE-PROVIDER early

    Now junk in MM-SERVICE-PROVIDER will lead to a client side error,
    instead of a server-side one.

    Change-Id: Ic930b4093fe005c3abc6c8561ee1114846fb80a6
    Closes-Bug: #1705773

Changed in mixmatch:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.