MARC batch edit progress reporting is wastefully verbose

Bug #1705731 reported by Galen Charlton
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.0
Fix Released
Undecided
Unassigned

Bug Description

The MARC batch edit interface currently reports its progress to the client by periodically updating an anon_cache key, which the client then fetches every second or so.

However, the contents of that key are a JSON array of the success/failure status of each bib record. In particular, as open-ils.cat.container.template_overlay.background processes each record, it tacks on an entry to the status array and pushes it to the anon_cache. The client, in turn, periodically fetches the entire array and sums up the number of successes and failures, but doesn't make any use of the record IDs that are sent.

For large batches of thousands of records, this yields a lot of network traffic, both inside Evergreen and outside of it. The former seems to be associated with open-ils.actor listeners occasionally getting backlogged and failing to relay requests promptly, thereby slowing down uses of open-ils.actor for purposes other than calling open-ils.actor.anon_cache.set_value. For that reason, I'm marking this as a bug rather than a wishlist.

It would be better if just the counts of successes and failures were passed along as the status update.

Evergreen 2.12+

Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available in the user/gmcharlt/lp1705731_slim_batch_edit_progress_reporting branch in the working repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1705731_slim_batch_edit_progress_reporting

tags: added: batch edit marc performance
Changed in evergreen:
milestone: none → 2.12.4
importance: Undecided → Medium
tags: added: pullrequest
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Galen. Patch reviewed and tested. Confirmed batch editing still performs as expected, MARC data is modified, totals are updated in the UI.

Merged to master and 2.12.

Changed in evergreen:
status: New → Confirmed
assignee: Bill Erickson (berick) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.