extra newline in deploy command in quickstart's overcloud-deploy.sh
Bug #1705252 reported by
James Slagle
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| tripleo |
Fix Released
|
Medium
|
Emilien Macchi | ||
Bug Description
The generated overcloud-deploy.sh script has an extra newline in the
"openstack overcloud deploy" command. This means that the last line of
the command is not taking effect, effectively making it so that
$DEPLOY_ENV_YAML and the use of $@ is ignored.
| Changed in tripleo: | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → James Slagle (james-slagle) |
| milestone: | none → pike-3 |
| Changed in tripleo: | |
| milestone: | pike-3 → pike-rc1 |
| Changed in tripleo: | |
| milestone: | pike-rc1 → queens-1 |
| tags: | added: quickstart |
| Changed in tripleo: | |
| milestone: | queens-1 → queens-2 |
| Changed in tripleo: | |
| assignee: | James Slagle (james-slagle) → Emilien Macchi (emilienm) |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to tripleo-quickstart-extras (master) | #1 |
| Changed in tripleo: | |
| status: | In Progress → Fix Released |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix included in openstack/tripleo-quickstart-extras 2.1.1 | #2 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 995838ab46170fd
Author: James Slagle <email address hidden>
Date: Wed Jul 19 07:48:30 2017 -0400
Fix extra newline in deploy command
The generated overcloud-deploy.sh script had an extra newline in the
"openstack overcloud deploy" command. This meant that the last line of
the command was not taking effect, effectively making it so that
$DEPLOY_
This patch uses jinja's replace() to strip the extra newline.
Closes-Bug: #1705252
Change-Id: I502b8e8ea3317d