subnetpools not cleaned up after subnetpool tempest tests

[Eric Berglund]

Openstack Version: master

Neutron change [1] introduced tempest tests for default subnetpools. These tests create subnetpools but do not clean them up after the test is complete. This results in subsequent tests failing because a default subnetpool already exists (see trace below). These subnetpools need to be deleted for the subsequent tests to succeed. [2] provides an example tempest run hitting this bug.

[1] https://github.com/openstack/neutron/commit/316e2f4
[2] http://184.172.12.213/39/484439/2/check/nova-out-of-tree-pvm/edcdcfa/powervm_os_ci.html

TRACE:
Traceback (most recent call last):
  File "tempest/test.py", line 122, in wrapper
    return func(*func_args, **func_kwargs)
  File "/opt/stack/neutron/neutron/tests/tempest/api/test_subnetpools.py", line 386, in test_convert_default_subnetpool_to_non_default
    is_default=True)
  File "/opt/stack/neutron/neutron/tests/tempest/api/test_subnetpools.py", line 49, in _create_subnetpool
    return cls.create_subnetpool(name=name, is_admin=is_admin, **kwargs)
  File "/opt/stack/neutron/neutron/tests/tempest/api/base.py", line 416, in create_subnetpool
    body = cls.admin_client.create_subnetpool(name, **kwargs)
  File "/opt/stack/neutron/neutron/tests/tempest/services/network/json/network_client.py", line 184, in create_subnetpool
    resp, body = self.post(uri, body)
  File "tempest/lib/common/rest_client.py", line 270, in post
    return self.request('POST', url, extra_headers, headers, body, chunked)
  File "tempest/lib/common/rest_client.py", line 659, in request
    self._error_checker(resp, resp_body)
  File "tempest/lib/common/rest_client.py", line 770, in _error_checker
    raise exceptions.BadRequest(resp_body, resp=resp)
tempest.lib.exceptions.BadRequest: Bad request
Details: {u'message': u'Invalid input for operation: A default subnetpool for this IP family has already been set. Only one default may exist per IP family.', u'type': u'InvalidInput', u'detail': u''}

[Dongcan Ye (hellochosen)]

These default subnetpools should be deleted at [1]:
https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/base.py#L180-L186

What am I missing here?

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Bug closed due to lack of activity, please feel free to reopen if needed.