Container upgrade job not respecting depends-on from t-h-t to puppet-tripleo

[Jiří Stránský]

When there's a depends-on pointing from a t-h-t patch to a puppet-tripleo patch, it doesn't work in the containers upgrade job.

E.g. this patch https://review.openstack.org/#/c/482170/6 fails with:

Could not find class ::tripleo::profile::base::iscsid

even though it has depends-on pointing to

https://review.openstack.org/#/c/482166/5

[Jiří Stránský (jistr)]

I would think that this covers the depends-on:

https://github.com/openstack-infra/tripleo-ci/blob/0dbe82a056947b7257e204930b0aebdaae473170/toci-quickstart/playbooks/multinode.yml#L123-L127

..but it doesn't seem to be the case.

[Attila Darazs (adarazs)]

I addition to the repo-setup, we should also add the install-built-repo role, like we do in the normal job process:

https://github.com/openstack-infra/tripleo-ci/blob/0dbe82a056947b7257e204930b0aebdaae473170/toci-quickstart/playbooks/multinode.yml#L61

also in the case of updates/upgrades, we should probably not run the install-built-repo role before the update/upgrade, only at the second repo-setup before the update/upgrade.

Help for debugging: when the gating repo is properly injected and used there should be some @gating-repo entries in this file and I don't see any:

http://logs.openstack.org/70/482170/6/check/gate-tripleo-ci-centos-7-containers-multinode-upgrades-nv/4dae958/logs/subnode-2/var/log/extra/yum-list-installed.txt.gz

For example in the same job, I see THT & puppet-tripleo being used from the "@gating-repo" on the undercloud:

http://logs.openstack.org/70/482170/6/check/gate-tripleo-ci-centos-7-containers-multinode-upgrades-nv/4dae958/logs/undercloud/var/log/extra/yum-list-installed.txt.gz

Our update/upgrade testing path needs some additional work to make this work as expected. Especially for containerized deployments.

[Jiří Stránský (jistr)]

The fix has been merged at https://review.openstack.org/#/c/483387/