ICMP type-code is not set using CLI create SG rule

[Vinh Nguyen]

Version:
Using openstack CLI version: 3.8.1.

Problem: When create ICMP security group rule with type code = 0, the 'port_range_max' of the created rule is 'None'. The correct value should be '0' as the value of the type_code.

Steps:

Steps:
1. Create Security groups,
   openstack security group create sg1

2. Associate rules to SG,

     openstack security group rule create --ingress --protocol icmp --icmp-type 8 --icmp-code 0 sg1
     openstack security group rule create --egress --protocol icmp --icmp-type 8 --icmp-code 0 sg1

Observation: Rule is created with port_range_max == Node.

+-------------------+--------------------------------------+
| Field | Value |
+-------------------+--------------------------------------+
| created_at | 2017-07-11T21:26:02Z |
| description | |
| direction | ingress |
| ether_type | IPv4 |
| id | d09f67e2-fa63-48f4-9553-851db212736f |
| name | None |
| port_range_max | None |
| port_range_min | 8 |
| project_id | 8981c66499a24a0e8ed7dc626d9703ef |
| protocol | icmp |
| remote_group_id | None |
| remote_ip_prefix | 0.0.0.0/0 |
| revision_number | 1 |
| security_group_id | 5c11a4f0-7cf2-47c3-8a89-2f773a862f91 |
| updated_at | 2017-07-11T21:26:02Z |
+-------------------+--------------------------------------+

Expected: The port_range_max should be 0

[Venkatrangan Govindarajan (venkatrangang)]

Patch Added here
https://review.openstack.org/#/c/505890/

[Julie Pichon (jpichon)]

Updating status to "Fix Committed" as the patch referenced in comment #1 merged on master on Sept 27.