designate-dashboard UT failure due to KeyError in HORIZON_CONFIG['plugins']

[Akihiro Motoki]

designate-dashboard UT failure

http://logs.openstack.org/82/480782/1/check/gate-designate-dashboard-python27-ubuntu-xenial/e83a6de/console.html#_2017-07-06_01_38_23_540405

It seems we cannot assume 'plugins' always exists in HORIZON_CONFIG.

2017-07-06 01:38:23.540524 | Traceback (most recent call last):
2017-07-06 01:38:23.540609 | File "/home/jenkins/workspace/gate-designate-dashboard-python27-ubuntu-xenial/designatedashboard/tests/test_designatedashboard.py", line 147, in setUp
2017-07-06 01:38:23.540642 | super(AAAARecordFormTests, self).setUp()
2017-07-06 01:38:23.540687 | File "/home/jenkins/workspace/gate-designate-dashboard-python27-ubuntu-xenial/designatedashboard/tests/base.py", line 74, in setUp
2017-07-06 01:38:23.540712 | super(BaseRecordFormCleanTests, self).setUp()
2017-07-06 01:38:23.540768 | File "/home/jenkins/workspace/gate-designate-dashboard-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/openstack_dashboard/test/helpers.py", line 193, in setUp
2017-07-06 01:38:23.540788 | super(TestCase, self).setUp()
2017-07-06 01:38:23.540841 | File "/home/jenkins/workspace/gate-designate-dashboard-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/horizon/test/helpers.py", line 128, in setUp
2017-07-06 01:38:23.540871 | self._setup_test_data()
2017-07-06 01:38:23.540931 | File "/home/jenkins/workspace/gate-designate-dashboard-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/openstack_dashboard/test/helpers.py", line 200, in _setup_test_data
2017-07-06 01:38:23.540959 | 'JS_CATALOG': context_processors.get_js_catalog(settings),
2017-07-06 01:38:23.541029 | File "/home/jenkins/workspace/gate-designate-dashboard-python27-ubuntu-xenial/.tox/py27/local/lib/python2.7/site-packages/openstack_dashboard/context_processors.py", line 110, in get_js_catalog
2017-07-06 01:38:23.541057 | all_plugins = conf.HORIZON_CONFIG['plugins']
2017-07-06 01:38:23.541073 | KeyError: 'plugins'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/481591

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481591
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f50cce4c1c337cf8d0fe355afe9a7db5a40d8d0b
Submitter: Jenkins
Branch: master

commit f50cce4c1c337cf8d0fe355afe9a7db5a40d8d0b
Author: Akihiro Motoki <email address hidden>
Date: Fri Jul 7 11:33:40 2017 +0000

    Fix KeyError for HORIZON_CONFIG['plugins'] in plugin UT

    HORIZON_CONFIG['plugins'] does not always exist.
    It breaks unit tests of some horizon plugins like designate-dashboard.

    Change-Id: I23aae10a7e63494c1c9f656b47becd2f067c9058
    Closes-Bug: #1702889

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.0.0b3 development milestone.