Browser patron register UI fails to load

[Bill Erickson]

Evergreen 2.12

Commented originally in bug #1696495.

Patron register interface (https://HOSTNAME/eg/staff/circ/patron/register) no longer loads.

The first console error:

angular.js:14199 TypeError: Cannot read property 'home_ou' of undefined
    at m.$scope.handle_home_org_changed (regctl.js:1628)
    at regctl.js:1210
    at angular.js:16696
    at m.$eval (angular.js:17994)
    at m.$digest (angular.js:17808)
    at angular.js:18033
    at f (angular.js:6045)
    at angular.js:6324

This is followed by various other console errors. During page load, it looks like $scope.patron is null when it's expected to have a value (around line 1189 / $scope.patron = prs.patron)

For context, reverting the following commit prevents the issue. Likely a small tweak to this commit is all that's needed.

http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=997e277207b4051b028d93bcab26c70645663081

[Cesar V (cesardv)]

Taking a look at this now...

[Cesar V (cesardv)]

I've added a fix for the issue here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1702756_correct_regctl_bug

[Cesar V (cesardv)]

Bill, thanks for finding this, and sorry for the delay in getting proper a fix out.

Since I made patronRegSvc.init_patron() return a promise of an initialized patron in order to fix the related caching issue/bug when loading existing patrons, it also needed to do the same for a new patron (which just returns an empty patron with some default values). Please feel free to pull that branch I pushed and check it out. I appreciate all feedback! Still learning here :)

[Josh Stompro (u-launchpad-stompro-org)]

Hello, I'm testing this on master, I can confirm that with a ~7/18/2017 build the problem is still there.

After loading this patch I can now load the register patron page and create a new user. The form also displays fine when editing a patron record. I don't see any errors in the console.

Signoff branch - user/stompro/lp1702756_correct_regctl_bug_signoff
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1702756_correct_regctl_bug_signoff

Josh

[Galen Charlton (gmc)]

Pushed to master and rel_2_12. Thanks, Cesar and Josh!