external network with subnet on network topology does not have subnet listed in pop up dialog when click

[Gloria Gu]

Based on latest master as of 7/6/2017

How to reproduce:

As a admin user, find an external network which has a subnet or create an external network with subnet in admin -> network panel

Go to network topology, graph tab, click the network icon created above, it should pop up a small dialog. The subnet is not listed and no delete subnet button.

Expected:
the subnet should show up for an external network and there is a delete subnet button.

[Gloria Gu (gloria-gu)]

horizon.networktopology.js

in the following block
 nodeEnter.on('click', function(d) {
      self.show_balloon(d.data, d, angular.element(this));
    });

d.data has subnets empty

[Gloria Gu (gloria-gu)]

horizon.networktopologycommon.js, data comes in with empty subnet
update:function() {
    var self = this;
    angular.element.getJSON(
      angular.element('#networktopology').data('networktopology') + '?' + angular.element.now(),
      function(data) {
        self.model = data;
        $('#networktopology').trigger('change');
        self.update_timer = setTimeout(function(){
          self.update();
        }, self.reload_duration);
      }
    );
  },

[Gloria Gu (gloria-gu)]

network_topology views.py the following code cause add_resource_url to fail silently
for subnet in publicnet.subnets:
                        snet = {'id': subnet.id,
                                'cidr': subnet.cidr}
                        self.add_resource_url(
                            'horizon:project:networks:subnets:detail', snet)
                        subnets.append(snet)
                except Exception:
                    subnets = []

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/481320

[Lucas H. Xu (xuh-2)]

I cannot reproduce this bug now. I was able to confirm. Maybe a fix in another patch?

[Gloria Gu (gloria-gu)]

@Lucas, in the process of rebuilding system...once it is up...will try again.

[Gloria Gu (gloria-gu)]

@Lucas, I checked the latest master code ...looks like the problem is still there:

in network_topology/views.py
line 306 snet is an object
line 308 call self.add_resource_url with snet object

line 211 where add_resource_url is defined...line 223, it will fail here silently since snet is not an array.

openstack system setup doesn't seem to be happy, I have to reset it up again...but I expect the problem should still exist.

[Lucas H. Xu (xuh-2)]

Thanks for updating this. We may be Rob and other people to help us confirm this. I still cannot reproduce this. Thanks!

[Akihiro Motoki (amotoki)]

I cannot reproduce this in the latest commit as well (commit 7640903b2b5c91c00bbac1a9aeef6d893f7f14eb).

https://review.openstack.org/#/c/465778/ improves the logic which retrieve network_get, but I am not sure this is related to this bug and the reproduce-ability.

[Gloria Gu (gloria-gu)]

@Akihiro, @Lucas I am not actively working on Horizon. If it is not reproducible, please close this.

[Akihiro Motoki (amotoki)]

@Gloria,
Looking at the proposed patch, it seems the reported issues is NOT about a general network with subnets.
It is specific to an external network ("router:external" network attribute is True). Is it right?
If so the issue still exists but the bug description and title should be updated.

Temporarily I mark this Incomplete.

[Gloria Gu (gloria-gu)]

@Akihiro, I will take a look again...and let you know.

[Gloria Gu (gloria-gu)]

Tried with latest master...noticed there are some changes .... before it was just creating a non-shared network can observe the problem. Now ...creating a non-shared network seems to be ok now. But if the network is an external network type...it still has the problem.

@Akihiro, I pasted the external network data printed from running the latest master code. I masked some of the real ides and ip addresses.

<Network: {u'provider:physical_network': None, u'updated_at': u'2017-10-04T22:49:39Z', u'dns_domain': u'', u'revision_number': 5, u'provider:network_type': u'vxlan', u'id': u'11111111111111111', u'router:external': True, u'availability_zone_hints': [], u'availability_zones': [u'nova'], u'router__external': True, u'ipv4_address_scope': None, u'shared': False, u'project_id': u'11111111111111111', u'status': u'ACTIVE', u'subnets': [<Subnet: {u'service_types': [], u'description': u'', u'enable_dhcp': False, u'network_id': u'11111111111111111', u'tenant_id': u'11111111111111111', u'created_at': u'2017-10-04T22:49:39Z', u'dns_nameservers': [], u'updated_at': u'2017-10-04T22:49:39Z', 'ipver_str': 'IPv4', u'ipv6_ra_mode': None, u'allocation_pools': [{u'start': u'1.2.2.3', u'end': u'12.3.4.5}], u'gateway_ip': u'1.2.3.6', u'revision_number': 2, u'ipv6_address_mode': None, u'ip_version': 4, u'host_routes': [], u'cidr': u'1.1.1.1/16', u'project_id': u'11111111111111111', u'id': u'11111111111111111', u'subnetpool_id': None, u'name': u''}>], u'provider__network_type': u'vxlan', u'provider__physical_network': None, u'description': u'', u'tags': [], u'ipv6_address_scope': None, u'is_default': False, 'admin_state': 'UP', u'provider:segmentation_id': 1111, u'name': u'ext-net', u'admin_state_up': True, u'tenant_id': u'11111111111111111', u'created_at': u'2017-10-04T22:49:32Z', u'mtu': 1450, u'provider__segmentation_id': 1070}>

I applied the changes in the review...it seems to work.

[Gloria Gu (gloria-gu)]

Think the changes still valid.

[Akihiro Motoki (amotoki)]

Thanks for the clarification.

Yes, subnet information of an external network is not shown. It is not easy to know a current user has enough permission to show subnet on an external network. Perhaps what we need is to try to retrieve subnet information and to return subnet information if it is retrieved successfully.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481320
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f20dacf466c982e737c5ee79ae675d8d12e1e65d
Submitter: Jenkins
Branch: master

commit f20dacf466c982e737c5ee79ae675d8d12e1e65d
Author: gugl <email address hidden>
Date: Thu Jul 6 16:38:47 2017 -0700

    Fix subnet no show in networktopology graph

    This checkin is to fix:

    When login as admin, non-shared network's subnet failed to show
    up in network toplogy graph when click on the network which
    has subnets.

    Change-Id: I3677b33eb234e70e69ee9a9231de13cafe970c0f
    Closes-bug: #1702739

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.