Scheduler hints are not properly disabled (Launch instance)

[Pascal Boutin]

We disabled the "enable_scheduler_hints" in the "LAUNCH_INSTANCE_DEFAULTS" of our local_settings.py and sometimes the step is still visible from the launch instance modal.

It looks like a race condition where the settings aren't loaded in time before the modal shows up. Opening the modal after the settings have correctly resolve prevent this error from happening, so it makes this problem appears only on the first opening of the modal.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/482682

[Ying Zuo (yingzuo)]

Is there a good way to reproduce this issue? Seems to be working fine for me.

[Mathieu Gagné (mgagne)]

Try disabling more than 2 steps:
* Server Groups (with policy)
* Scheduler Hints (with policy and/or LAUNCH_INSTANCE_DEFAULTS)

The issue shows when you try to disable more than 1 step as the index of the 2nd and following steps are shift in the array after the 1st splice.

You will find that the step after Scheduler Hints (Metadata) won't show anymore.

[Ying Zuo (yingzuo)]

Thanks Mathieu. I am able to reproduce the issue mentioned in comment #3.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/482682
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e742950da140fa12d078b495a2b8da64c64bd142
Submitter: Zuul
Branch: master

commit e742950da140fa12d078b495a2b8da64c64bd142
Author: Mathieu Gagné <email address hidden>
Date: Tue Jul 11 15:48:19 2017 -0400

    Remove the errored steps after they all responded

    Removing steps during the initial loop could cause some issues and race
    conditions.

    This change makes it so the steps are filtered out after they all responded.
    Since it waits for the global resolve to moves on, this change should not
    make anything slower.

    Closes-bug: #1702728
    Change-Id: Iabfdd3445117b898251782969c3d915b802f440e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/520250

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/520250
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0155d24f1a873c5bbccc02dc889a257660e15696
Submitter: Zuul
Branch: stable/pike

commit 0155d24f1a873c5bbccc02dc889a257660e15696
Author: Mathieu Gagné <email address hidden>
Date: Tue Jul 11 15:48:19 2017 -0400

    Remove the errored steps after they all responded

    Removing steps during the initial loop could cause some issues and race
    conditions.

    This change makes it so the steps are filtered out after they all responded.
    Since it waits for the global resolve to moves on, this change should not
    make anything slower.

    Closes-bug: #1702728
    Change-Id: Iabfdd3445117b898251782969c3d915b802f440e
    (cherry picked from commit e742950da140fa12d078b495a2b8da64c64bd142)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.2 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/542836

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Gutman (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/542836
Reason: too late for ocata