Convergence: Fail to re-trigger replacement

[Rico Lin]

Fail to re-trigger replacement with following error

ERROR oslo_messaging.rpc.server [None req-09c52e39-901f-45bf-8e9e-51b3ae37e765 admin None] Exception during message handling: TypeError: __init__() takes exactly 6 arguments (5 given)
ERROR oslo_messaging.rpc.server Traceback (most recent call last):
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/server.py", line 153, in _process_incoming
ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 213, in dispatch
ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/oslo_messaging/rpc/dispatcher.py", line 183, in _do_dispatch
ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
ERROR oslo_messaging.rpc.server File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 153, in wrapper
ERROR oslo_messaging.rpc.server return f(*args, **kwargs)
ERROR oslo_messaging.rpc.server File "/opt/stack/heat/heat/common/context.py", line 399, in wrapped
ERROR oslo_messaging.rpc.server return func(self, ctx, *args, **kwargs)
ERROR oslo_messaging.rpc.server File "/opt/stack/heat/heat/engine/worker.py", line 173, in check_resource
ERROR oslo_messaging.rpc.server self._retrigger_replaced(is_update, rsrc, stack, msg_queue)
ERROR oslo_messaging.rpc.server File "/opt/stack/heat/heat/engine/worker.py", line 145, in _retrigger_replaced
ERROR oslo_messaging.rpc.server cr = check_resource.CheckResource(self.engine_id, self._rpc_client,
ERROR oslo_messaging.rpc.server TypeError: __init__() takes exactly 6 arguments (5 given)
ERROR oslo_messaging.rpc.server

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/480607

[Zane Bitter (zaneb)]

Caused by https://review.openstack.org/#/c/435164/ which fortunately landed only in Pike, so no backports required.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/480607
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6d7506c690ff84ccc34b3a4b8ad96f22012c4ab9
Submitter: Jenkins
Branch: master

commit 6d7506c690ff84ccc34b3a4b8ad96f22012c4ab9
Author: ricolin <email address hidden>
Date: Wed Jul 5 22:20:34 2017 +0800

    Fix _retrigger_replaced in convergence worker

    Fix missing argument in _retrigger_replaced when calling
    CheckResource.
    Closes-Bug: #1702487

    Change-Id: Idc81b50fcc7036aa90f1489a348572ef03aa3381

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/487647

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rico Lin (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/487647
Reason: we don't actually need this in ocata

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 9.0.0.0b3 development milestone.