thread_group_close does not unlock mutex in error branches
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Percona Server moved to https://jira.percona.com/projects/PS | Status tracked in 5.7 | |||||
5.5 |
Fix Released
|
High
|
Zsolt Parragi | |||
5.6 |
Fix Released
|
High
|
Zsolt Parragi | |||
5.7 |
Fix Released
|
High
|
Zsolt Parragi |
Bug Description
Spotted over at MariaDB:
https:/
diff --git a/sql/threadpoo
index 6075c758e405.
--- a/sql/threadpoo
+++ b/sql/threadpoo
@@ -979,24 +979,26 @@ static void thread_
if (pipe(thread_
{
- DBUG_VOID_RETURN;
+ goto end;
}
/* Wake listener */
if (io_poll_
{
- DBUG_VOID_RETURN;
+ goto end;
+ }
+ {
+ char c= 0;
+ if (write(
+ goto end;
}
- char c= 0;
- if (write(
- DBUG_VOID_RETURN;
-
/* Wake all workers. */
while(
{
}
+end:
mysql_
DBUG_
tags: | added: low-hanging-fruit threadpool |
https:/ /github. com/percona/ percona- server/ pull/1989 /github. com/percona/ percona- server/ pull/1990 /github. com/percona/ percona- server/ pull/1991
https:/
https:/