OpenStack Heat

stack update rollback with wrong tags

Bug #1702251 reported by huangtianhua on 2017-07-04

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Heat	Fix Released	Medium	huangtianhua	OpenStack Heat queens-1

Bug Description

In legacy:
1. create a stack with tags [t1, t2]
2. update the stack with new tags [t3, t4], and enable rollback
3. the stack update failed and rollback success
4. stack-show the tags of the stack is still [t3, t4]

I took a test update rollback in convergence, seems not only tags is wrong also disable_rollback and timeout_mins are the new values passed when stack-update.
This bug will fix the case in legacy, I have registried a bug for convergence:
https://bugs.launchpad.net/heat/+bug/1702277

See original description

Tags:

huangtianhua (huangtianhua) on 2017-07-04

Changed in heat:
assignee:	nobody → huangtianhua (huangtianhua)
importance:	Undecided → Medium

huangtianhua (huangtianhua) on 2017-07-04

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-04: Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/480153

Changed in heat:
status:	New → In Progress

huangtianhua (huangtianhua) on 2017-07-05

Changed in heat:
milestone:	none → pike-3

Rico Lin (rico-lin) on 2017-07-31

Changed in heat:
milestone:	pike-3 → pike-rc1

Rabi Mishra (rabi) on 2017-08-12

Changed in heat:
milestone:	pike-rc1 → pike-rc2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-21: Fix merged to heat (master)

Reviewed: https://review.openstack.org/480153
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=9e81190e74c8979ba39a8815e88f998d93364de4
Submitter: Jenkins
Branch: master

commit 9e81190e74c8979ba39a8815e88f998d93364de4
Author: huangtianhua <email address hidden>
Date: Tue Jul 4 19:12:50 2017 +0800

Rollback stack with correct tags

Set old tags for old_stack to make sure the stack
with the correct tags after rollback.

Change-Id: I8450df08c84b5a467ab8ac991451c5b108ee96e7
Closes-Bug: #1702251

Changed in heat:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-22: Fix proposed to heat (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/496056

Rico Lin (rico-lin) on 2017-08-22

Changed in heat:
milestone:	pike-rc2 → queens-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-08-23: Fix merged to heat (stable/pike)

Reviewed: https://review.openstack.org/496056
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=520872ce4a75f308002fbaae7034fc2c51f237d9
Submitter: Jenkins
Branch: stable/pike

commit 520872ce4a75f308002fbaae7034fc2c51f237d9
Author: huangtianhua <email address hidden>
Date: Tue Jul 4 19:12:50 2017 +0800

Rollback stack with correct tags

Set old tags for old_stack to make sure the stack
with the correct tags after rollback.

    Change-Id: I8450df08c84b5a467ab8ac991451c5b108ee96e7
    Closes-Bug: #1702251
    (cherry picked from commit 9e81190e74c8979ba39a8815e88f998d93364de4)