Update firewall rule with a protocol fails

[Adit Sarfaty]

Create a firewall rule via horizon with UDP protocol, and later try to update it to TCP.

The Horizon UI will show this error:
Error: Failed to update rule non shared rule: Invalid input for protocol. Reason: TCP is not in valid_values. Neutron server returns request_ids: ['req-66afa587-cafb-4e6d-8229-8081e8092437']

and the logs:
2017-06-26 05:35:37.708918 DEBUG:urllib3.connectionpool:http://10.160.90.203:9696 "PUT //v2.0/fw/firewall_rules/507f825b-6798-410f-bab7-41c4dcd7d99b HTTP/1.1" 400 136
2017-06-26 05:35:37.709929 ERROR openstack_dashboard.dashboards.project.firewalls.forms Failed to update rule 507f825b-6798-410f-bab7-41c4dcd7d99b: Invalid input for protocol. Reason: TCP is not in valid_values.
2017-06-26 05:35:37.709938 Neutron server returns request_ids: ['req-66afa587-cafb-4e6d-8229-8081e8092437']
2017-06-26 05:35:37.710425 WARNING horizon.exceptions Recoverable error: Invalid input for protocol. Reason: TCP is not in valid_values.

The reason is that the protocols should be sent to neutron in lower-case.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Adit Sarfaty (<email address hidden>) on branch: master
Review: https://review.openstack.org/477380
Reason: Should be fixed in neutron-fwaas-dashboard

[Adit Sarfaty (asarfaty)]

Seems to work fine in Neutron FWaaS dashboard.
This bug only exists openstack dashboard before the split.

[Akihiro Motoki (amotoki)]

All fixes should go to neutron-fwaas-dashboard, so I mark the status in horizon as Won't Fix.

[Akihiro Motoki (amotoki)]

Per Adit comment in #4, I mark the status in FWaaS dashboard side as Invalid.

[Akihiro Motoki (amotoki)]

I hit this problem for protocol and action.
I got the following error message: Invalid input for protocol. Reason: ICMP is not in valid_values.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/500801

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/500801
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas-dashboard/commit/?id=e2d30b97cfb51fd46cb87cce6f6c779787f10fdd
Submitter: Jenkins
Branch: master

commit e2d30b97cfb51fd46cb87cce6f6c779787f10fdd
Author: Akihiro Motoki <email address hidden>
Date: Tue Sep 5 11:03:52 2017 +0000

    v1 dashboard: Fix a bug that rule cannot be updated

    Previously firewall rules cannot be updated because uppercase
    protocol names are passed to neutron server but FWaaS v1 API
    accepts only lowercase protocol names.

    There is no reason to use uppercase values in the dashboard
    code except the labels. This commit converts uppercase values
    in protocol and action into lowercase values.

    Closes-Bug: #1700449
    Change-Id: I4405f1bed4c29db32d8d6b35b99915d00baadf44

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/503855

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/503855
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas-dashboard/commit/?id=184ca620381347e6577191bcd5dbac9c9aab6688
Submitter: Jenkins
Branch: stable/pike

commit 184ca620381347e6577191bcd5dbac9c9aab6688
Author: Akihiro Motoki <email address hidden>
Date: Tue Sep 5 11:03:52 2017 +0000

    v1 dashboard: Fix a bug that rule cannot be updated

    Previously firewall rules cannot be updated because uppercase
    protocol names are passed to neutron server but FWaaS v1 API
    accepts only lowercase protocol names.

    There is no reason to use uppercase values in the dashboard
    code except the labels. This commit converts uppercase values
    in protocol and action into lowercase values.

    Closes-Bug: #1700449
    Change-Id: I4405f1bed4c29db32d8d6b35b99915d00baadf44
    (cherry picked from commit e2d30b97cfb51fd46cb87cce6f6c779787f10fdd)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-fwaas-dashboard 1.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-fwaas-dashboard 1.0.1 release.