Fix puppet initd script

Bug #1699799 reported by Fabrizio Soppelsa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
High
Max Yatsenko

Bug Description

MOS 9.2:

In the puppet initd file, for stop() there is:

```
PIDFILE="/run/puppet/${NAME}.pid"
...
stop_puppet_agent() {
        start-stop-daemon --stop --retry TERM/10/KILL/5 --quiet --oknodo --pidfile $PIDFILE
}
```

After stopping the puppet agent, this pidfile is not removed. Thus, it still includes a pid which is not updated ever, ie:

$ cat /run/puppet/agent.pid
1234

When puppet stop is invoked, the script will kill the process with pid 1234, whatever it is.

Changed in mos:
importance: Undecided → High
Max Yatsenko (myatsenko)
Changed in mos:
assignee: MOS Maintenance (mos-maintenance) → Max Yatsenko (myatsenko)
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/puppet (9.0)

Fix proposed to branch: 9.0
Change author: Max Yatsenko <email address hidden>
Review: https://review.fuel-infra.org/36051

Changed in mos:
status: New → In Progress
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/puppet (9.0)

Reviewed: https://review.fuel-infra.org/36051
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0

Commit: 4e2b00de2818b8f5627b7aec6c8a2a7ac54de6d7
Author: Max Yatsenko <email address hidden>
Date: Tue Jul 25 11:45:58 2017

Update puppet agent init script

It updates puppet init script to
remove a PIDFILE after puppet service
stopping.

Change-Id: Icb27964ee395fab2f393007ed192251416f8f56d
Closes-bug: #1699799

Changed in mos:
status: In Progress → Fix Committed
Revision history for this message
Vladimir Jigulin (vjigulin) wrote :

Verified on 9.0-2017-09-01 snapshot

Deploy without proposed:
root@node-1:~# cat /run/puppet/agent.pid
9304

Deploy with proposed:
root@node-1:~# cat /run/puppet/agent.pid
cat: /run/puppet/agent.pid: No such file or directory
root@node-1:~# ls /run/puppet/
root@node-1:~#

Changed in mos:
status: Fix Committed → Won't Fix
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.