Heat parameters have different defaults in templates

[Martin André]

Jon Schlueter compiled at https://paste.fedoraproject.org/paste/dlycC3PUZldfGhwWEqJHVA a list of Heat parameters that are being set several times in docker templates. From this list, DockerHeatConfigImage and DockerNovaComputeImage have different defaults, meaning it's racy and at least one is not honored:

❯ ag 'DockerHeatConfigImage:' -A 2
docker/services/heat-api-cfn.yaml
16: DockerHeatConfigImage:
17- description: image
18- default: 'centos-binary-heat-api-cfn:latest'

docker/services/heat-api.yaml
16: DockerHeatConfigImage:
17- description: image
18- default: 'centos-binary-heat-api:latest'

❯ ag 'DockerNovaComputeImage:' -A 2
docker/services/nova-ironic.yaml
11: DockerNovaComputeImage:
12- description: image
13- default: 'centos-binary-nova-compute-ironic:latest'

docker/services/nova-compute.yaml
11: DockerNovaComputeImage:
12- description: image
13- default: 'centos-binary-nova-compute:latest'

We should use different parameter names.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/476970

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/476970
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a474ae82d5f157a48c997fb9df420442bd79dcbe
Submitter: Jenkins
Branch: master

commit a474ae82d5f157a48c997fb9df420442bd79dcbe
Author: Martin André <email address hidden>
Date: Fri Jun 23 18:21:43 2017 +0200

    Add heat parameter for all of config_volume images

    This commit consistently defines a heat template parameter in the form
    of DockerXXXConfigImage where XXX represents the name of the
    config_volume that is used by docker-puppet.

    The goal is to mitigate hard to debug errors where the templates would
    set different defaults for the image docker-puppet.py uses to run, for
    the same config_volume name.

    This fixes a couple of inconsistencies on the way.

    Change-Id: I212020a76622a03521385a6cae4ce73e51ce5b6b
    Closes-Bug: #1699791

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b3 development milestone.