Glance writes stack trace to logs in correct situations

[Kairat Kushaev]

When missing images are requested with glance API v1, long python-style
traceback is stored in glance-api log file. This affects many monitoring
systems and complicates the investigation of real techical issues.
we need get rid of this long stack trace and show error message only.
This affects only glance with registry backend- so it is not applicable to glance v2 and affects v1 only.
Test Case:
1.install openstack cloud, enable v1 registry for glance
2. glance --image-api-version 1 image-show not_existing
AR:a long stack trace with NotFound exception in /var/log/glance/api.log
ER: a short message with 404 exception in /var/log/glance.api.log

[Kairat Kushaev (kkushaev)]

https://bugs.launchpad.net/glance/+bug/1533970
https://bugs.launchpad.net/glance/+bug/1654270- upstream bugs. upstream fix were rejected cause v1 is not supported in upstream

[Kairat Kushaev (kkushaev)]

https://review.fuel-infra.org/#/c/35695/ - MOS 8.x
https://review.fuel-infra.org/#/c/35695/ - MOS 9.x

[Danil Akhmetov (dinobot)]

Important notice: this patch also requires another change which happened in Newton.

[1] https://bugs.launchpad.net/glance/+bug/1450209
[2] https://review.openstack.org/#/c/355960/

That patch is a workaround, and we still should rise the proper exception there.

Originally I faced this issue when StackLight started generating hundreds of CRIT alerts for Glance. To my surprise, I found Glance fully operational: I investigated this issue and proposed the patch quick.

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Kairat Kushaev <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/35695
Reason: Seems thathttps://review.fuel-infra.org/#/c/35730/ is enough to fix the issue

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Kairat Kushaev <email address hidden> on branch: 9.0/mitaka
Review: https://review.fuel-infra.org/35693
Reason: Seems thathttps://review.fuel-infra.org/#/c/35730/ is enough to fix the issue

[Kairat Kushaev (kkushaev)]

I proposed patches that actually fix the issues:
 https://review.fuel-infra.org/#/c/35730/ - 9.0
tps://review.fuel-infra.org/#/c/35731/ - 8.0

[Kairat Kushaev (kkushaev)]

https://mirantis.my.salesforce.com/5004400000jFwSL?srPos=3&srKp=500 - salesforce ticket

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/35731
Submitter: Pkgs Jenkins <email address hidden>
Branch: openstack-ci/fuel-8.0/liberty

Commit: 3eb8ee7adce08d64605d5ce799b8c14704a95c9b
Author: Sean Dague <email address hidden>
Date: Thu Jun 22 12:11:39 2017

Stop stack tracing on 404s

Glance has had this persistent bit of log noise where trying to GET a
non existent image creates a stack trace at ERROR log level. This
makes glance api logs extra noisy, and confuses when actual errors
happen.
(cherry-picked from commit 5caf1c739e190338e87be8bcd880cb88b0920299)
Conflicts:
       glance/registry/client/v1/client.py
Closes-Bug:#1699512
Change-Id: Ic08f3a3885f31433f2416e317b412e743512f797

[Dmitry (dtsapikov)]

Verified on 8.0+mu5

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/35730
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0/mitaka

Commit: 8bb07dcc8ac414ed5f59e6f134f67c61abf6eb74
Author: Sean Dague <email address hidden>
Date: Thu Jun 22 09:05:36 2017

Stop stack tracing on 404s

Glance has had this persistent bit of log noise where trying to GET a
non existent image creates a stack trace at ERROR log level. This
makes glance api logs extra noisy, and confuses when actual errors
happen.
(cherry-picked from commit 5caf1c739e190338e87be8bcd880cb88b0920299)
Closes-Bug: #1699512
Change-Id: Ic08f3a3885f31433f2416e317b412e743512f797

[Ilya Bumarskov (ibumarskov)]

Can't reproduce bug on Fuel 9.2 MU-2. We get HTTP 200 on request "glance --os-image-api-version 1 image-show not_existing" instead 404 error. However bug also isn't reproducible on MU-3 (snapshots/9.0-2017-10-09-094324).