[needs-packaging] vala-panel-appmenu

[Martin Wimpress ]

A global menu implementation for Vala Panel, Budgie Desktop, MATE Desktop and XFCE. unity-gtk-module is used as the backend.

  * vala-panel-appmenu

URL: https://github.com/rilian-la-te/vala-panel-appmenu
License: LGPL-3.0
Notes: I'm working upstream to maintain the packaging for vala-panel-appmenu and will ask the DMB to allow vala-panel-appmenu to be included in the the Ubuntu MATE package set so I can maintain it in the Ubuntu archive. vala-panel-appmenu has a dependency on vala-panel which has the following needs-packaging bug (LP: #1699333)

vala-panel-appmenu is not suitable for upload to Debian since Debian is missing some dependencies that vala-panel-appmenu requires, such as appmenu-qt5 and unity-gtk-module.

[needs-packaging] vala-panel-appmenu

The source and documentation is available from the following repository:

  * https://github.com/rilian-la-te/vala-panel-appmenu

The packaging can be found here:

  * https://github.com/rilian-la-te/vala-project-packages

A .dsc can be downloaded from ppa:flexiondotorg/needs-packaging using:

    dget -u -x https://launchpad.net/~flexiondotorg/+archive/ubuntu/needs-packaging/+files/vala-panel-appmenu_0.5.2-0ubuntu1.dsc

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Didier Roche-Tolomelli (didrocks)]

Great work!
I looked at the source packages (not binary build yet, but we'll do when NEWing), all looks good to me, but one issue in debian/copyright:

Files: unity-gtk-module/*
Copyright: 2012 Canonical Ltd.
License: LGPL-3.0+

-> this is wrong, the unity-gtk-module are just license LGPL-3.0, not +/or later. Please fix this and then we can sponsor :)

[Mattia Rizzolo (mapreri)]

Also,

in d/rules:
1) why is dh_strip called manually for each binary package?
2) why is dh_installgsettings "hidden" in a "if ubuntu.." check?

d/copyright:
3) cmake/* has files with copyright from various people with what looks like a BSD-2-clause license, not what you wrote
4) what didrocks said
5) unity-gtk-module/tests/autopilot/__init__.py has a 2013 copyright, so it needs expanding
6) unity-gtk-module/tests/demos has a 2011 copyright, so it needs expanding
7) copyright for Konstantin is till 2017, but all the claims I can find are only till 2016

The rest LGTM :)

[Martin Wimpress  (flexiondotorg)]

Thank you both for the review!

1) Thanks. Resolved.
2) I agree. That should be a distro maintainer override. Removed.
3) Thanks. Updated accordingly.
4) Thanks. Also updated.
5) Resolved.
6) Resolved.
7) Resolved.

[Martin Wimpress  (flexiondotorg)]

An updated .dsc can be downloaded from ppa:flexiondotorg/needs-packaging using:

    dget -u -x https://launchpad.net/~flexiondotorg/+archive/ubuntu/needs-packaging/+files/vala-panel-appmenu_0.5.2-0ubuntu1.dsc

[Mattia Rizzolo (mapreri)]

cool, uploaded!

[Andy Whitcroft (apw)]

All of the requested changes looks to have been applied. Looks reasonable enough.