FFmpeg debug assert in analyzerqueue
Bug #1698678 reported by
Daniel Schürmann
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
Critical
|
Unassigned |
Bug Description
A Debug debug assert fails with recent master build an FFmpeg, analyzing a m4a track:
Debug [AnalyzerQueue 1]: SoundSourceFFmpeg - readFramesToCache: Packet too big or File end
Critical [AnalyzerQueue 1]: DEBUG ASSERT: "framesRead <= framesToRead" in function bool AnalyzerQueue:
framesRead = 4096 and framesToRead = 1024
this cause additional follow up failing debug asserts, because we use the invalid framesRead.
Changed in mixxx: | |
importance: | Undecided → Critical |
Changed in mixxx: | |
status: | Confirmed → In Progress |
Changed in mixxx: | |
status: | In Progress → Fix Committed |
Changed in mixxx: | |
milestone: | none → 2.1.0 |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
AnalyzerQueue should only request framesToRead instead of kAnalysisFrames PerBlock frames. On the other hand SoundSourceFFmpeg should limit the requested number of frames appropriately and only return what is actually available.
A typical example of lazy implementation meets careless caller. Both could do better to prevent these kind of errors.