Canvas over clipped

[hilaire]

Canvas is overclipped in the DrGeo window.
It look like there is a shift in the canvas coordinate, origin locked to top left screen.

[Nicolai Hess (nicolaihess)]

This seems to be a bug in AthensCairoCanvas.
I made quite some changes for Pharo5 to make athens work better with drawing
ordinary Morphs and UI-Elements build from Morphs.

It was a pretty tough time especially for transformations and clipping.

I thing I made an error in
AthensCairoCanvas>>#clipRectangle
 ^ currentClipRect ifNil: [ 0 @ 0 extent: self surface extent ]

if the current clipRect is nil, I can not always create a default clip rect from the
surface extent, if the surface is actually transformed.

So, we have to make sure to take any (non-nil) path transform into account:

^ currentClipRect
  ifNil: [ pathTransform
    ifNotNil: [ (pathTransform inverted transform: 0 @ 0) extent: self surface extent ]
    ifNil: (0 @ 0 extent: self surface extent) ]

As the current release version and development process for Athens is pretty unclear
(pharo in-image and athens-repository again diverge, maybe we should fix this with a method overwrite from drgeo.

[hilaire (hilaire-fernandes)]

Yes, it will be nice

[hilaire (hilaire-fernandes)]

It is fixed in upstream Pharo 7.