tripleo_ui drop-down menus not displayed correctly

Bug #1698194 reported by wes hayutin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Honza Pokorny

Bug Description

The language options in the upper right corner of the tripleo_ui are misrendered in the latest master builds. See screen shot

Tags: ui
Revision history for this message
wes hayutin (weshayutin) wrote :
Revision history for this message
Julie Pichon (jpichon) wrote :

The same happens in Firefox, and this applies to the "Manage deployments" menu as well.

If I run the UI in dev mode with the same commit everything is displayed fine so it must be an issue with building the "production" version.

$ rpm -qa openstack-tripleo-ui # Shows the issues
openstack-tripleo-ui-7.1.1-0.20170612113546.64f5194.el7.centos.noarch

$ git log -n1 # Works fine
commit 64f5194cb10888ecf905f8d58aade211b00f46f1

Changed in tripleo:
status: New → Triaged
summary: - tripleo_ui language settings misrender in chrome
+ tripleo_ui language settings not displayed correctly
Revision history for this message
Julie Pichon (jpichon) wrote : Re: tripleo_ui language settings not displayed correctly
Revision history for this message
Honza Pokorny (hpokorny) wrote :

So, are we saying that if you run the UI from the git tree, it works but if you run it from an RPM, it fails?

In that case, it's likely that it's caused by the recently merged patch which introduces code minification.

Honza Pokorny (hpokorny)
Changed in tripleo:
assignee: nobody → Honza Pokorny (hpokorny)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/475089

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Julie Pichon (jpichon) wrote : Re: tripleo_ui language settings not displayed correctly

Bumping to "High" since the UI can't be released like that.

Changed in tripleo:
importance: Medium → High
summary: - tripleo_ui language settings not displayed correctly
+ tripleo_ui drop-down menus not displayed correctly
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/475089
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=af46edfd20e42f27047bff84f6708347d83f60dc
Submitter: Jenkins
Branch: master

commit af46edfd20e42f27047bff84f6708347d83f60dc
Author: Honza Pokorny <email address hidden>
Date: Fri Jun 16 20:19:59 2017 -0300

    Use component objects when comparing for type

    When dynamically introspecting components by type, use the component object
    itself instead of its name as a string. When comparing against a string, we
    create bugs due to code mangling: component names get truncated to shorter names
    to save space, and our equality checks don't work. Comparing against the
    component itself solves this problem without having to sacrifice mangling
    altogether.

    Change-Id: Ibca4db2d16dc169b81ce603551b0ab1bae4e7cf6
    Closes-Bug: 1698194
    Closes-Bug: 1699705

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 7.2.0

This issue was fixed in the openstack/tripleo-ui 7.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.