Add New Patron Fails with Wrong Error Message if DB Update Fails
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
2.12 |
Fix Released
|
Undecided
|
Unassigned | ||
3.0 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Evergreen Version 2.12.1
OpenSRF Version 2.5.0
PostgreSQL Version: 9.3+ N/A
If the database insert statement fails while adding a new user, the cstore editor die_event is returned improperly in the _add_patron helper function of OpenILS:
Rather than dying with the event message, the caller treats the event as the user object which leads to a later failure with the message: Can't call method "billing_address" on unblessed reference at /path/to/
For some more information, see the IRC conversation between Freddy_Enrique and Dyrcona beginning here: http://
Changed in evergreen: | |
milestone: | none → 3.1-beta |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
I forgot to link the branch, so here it is, rebased on master:
working/ user/dyrcona/ lp1698176_ add_patron_ die_event_ fix
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dyrcona/ lp1698176_ add_patron_ die_event_ fix