iscsi_ip_address HostAddressOpt config regression

[Eric Harney]

iscsi_ip_address used to be defined as an oslo.config StrOpt.

It was changed to an oslo.config HostAddressOpt.

This introduces a regression that breaks existing configs, because previously this setting would accept a value of "[fd00:fd00:3000::1]" -- now this is only accepted in the form "fd00:fd00:3000::1" with no brackets.

Using brackets results in:
"ConfigFileValueError: Value for option iscsi_ip_address is not valid: ('%s is not a valid host address', '[fd00:fd00:3000::1]')

We should revert back to the previous behavior and go through a deprecation path etc if there is a reason to actually change this behavior.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/474337

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/474337
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5f40f534b5804a37f5742fdc5011be51dcc65dd6
Submitter: Jenkins
Branch: master

commit 5f40f534b5804a37f5742fdc5011be51dcc65dd6
Author: Eric Harney <email address hidden>
Date: Mon May 29 19:22:03 2017 -0400

    Revert "Use HostAddressOpt for opts that accept IP and hostnames"

    This causes a compat problem for config files that were using
    IPv6 addresses formatted with brackets.

    Closes-Bug: #1697997

    This reverts commit 0a7ce3b2d77b4685cc293a39984805d12d3fd24a.

    Change-Id: I85aa2754b3cc37f65769e4958290f27e85f74f81

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.0.0.0b3 development milestone.