0.4.5-5 breaks for existing mojo projects

[Haw Loeung]

Hi,

0.4.5-5 (specifically r424) breaks for existing mojo projects. I think it's because of the change to is_setup where the sentinel_file for releases newer than Vivid is now "container_config_path/config.nonet". Unfortunately, this doesn't exist:

| [hloeung@wendigo lxc]$ sudo ls -la /var/lib/lxc/mojo-stg-ols-snap-store.xenial
| total 24
| drwxr-x--- 3 root stg-ols-snap-store 4096 Jun 13 01:29 .
| drwx--x--x 171 root mojo 12288 Apr 26 08:16 ..
| -rw-r--r-- 1 root root 664 Feb 3 01:32 config
| -rw-r--r-- 1 root root 0 Feb 3 01:32 fstab
| drwxr-xr-x 2 root root 4096 Feb 3 01:32 rootfs

Mojo thinks the container wasn't set up and fails as follows:

| The container project and series path for mojo-stg-ols-snap-store does not appear to exist at /srv/mojo/mojo-stg-ols-snap-store/xenial/ROOTFS/srv/mojo/mojo-stg-ols-snap-store/xenial.
| Check to make sure the project and series exist and permissions are set properly.
| Please run 'mojo project-new --series xenial mojo-stg-ols-snap-store' to create the project if needed.
| Or check the file permissions on /srv/mojo/mojo-stg-ols-snap-store/xenial/ROOTFS/srv/mojo/mojo-stg-ols-snap-store/xenial

[Paul Collins (pjdc)]

I ran into this with a couple of projects, and creating config.nonet let me proceed with using Mojo.

[Tom Haddon (mthaddon)]

This has been updated. If you could confirm the issue is fixed by updating the state of this bug that'd be great.

[Tim Kuhlman (timkuhlman)]

I just encountered the problem on wekufe,

(mojo-is-srvmgr)prodstack-is@wekufe:/srv/prodstack/is/specs/mojo-is-srvmgr$ mojo collect
2017-06-13 16:14:51 [INFO] Using pre-existing container class lxc
The container project and series path for mojo-is-srvmgr does not appear to exist at /srv/mojo/mojo-is-srvmgr/xenial/ROOTFS/srv/mojo/mojo-is-srvmgr/xenial.
Check to make sure the project and series exist and permissions are set properly.
Please run 'mojo project-new --series xenial mojo-is-srvmgr' to create the project if needed.
Or check the file permissions on /srv/mojo/mojo-is-srvmgr/xenial/ROOTFS/srv/mojo/mojo-is-srvmgr/xenial

[Haw Loeung (hloeung)]

Seems to be another case that we're not handling. _setup() creates config.nonet, _setup_legacy() creates etc/init/containersetup.conf, for a couple of these envs on wekufe, none of them exists which is odd.

[Haw Loeung (hloeung)]

Went with reverting to the behaviour before r424 and instead warn that project will break in future releases.