DeployArtifactURLs does not properly install rpms

Bug #1697102 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz

Bug Description

In attempting to verify that DeployArtifactURLs worked correctly with multiple urls (Bug 1649303), I noticed that attempting to use rpm urls with DeployArtifactURLs does not actually install the package. The files properly get downloaded but do not actually install because yum reports nothing to install.

To reproduce this you can run:
[root@undercloud-0 ~]# chmod a+x /usr/share/openstack-tripleo-heat-templates/puppet/deploy-artifacts.sh
[root@undercloud-0 ~]# artifact_urls="https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm http://yum.puppetlabs.com/puppetlabs-release-pc1-el-7.noarch.rpm" /usr/share/openstack-tripleo-heat-templates/puppet/deploy-artifacts.sh
  % Total % Received % Xferd Average Speed Time Time Time Current
                                 Dload Upload Total Spent Left Speed
100 14704 100 14704 0 0 12428 0 0:00:01 0:00:01 --:--:-- 12439
Loaded plugins: product-id, search-disabled-repos, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
No package /tmp/tmp.L4kMEufrLG/file_data available.
Error: Nothing to do
backed up to /tmp/tmp.EwRdOG29kG
  % Total % Received % Xferd Average Speed Time Time Time Current
                                 Dload Upload Total Spent Left Speed
100 13956 100 13956 0 0 8079 0 0:00:01 0:00:01 --:--:-- 8081
Loaded plugins: product-id, search-disabled-repos, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
No package /tmp/tmp.L4kMEufrLG/file_data available.
Error: Nothing to do
backed up to /tmp/tmp.yxndhBQkh6

Changed in tripleo:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/472847

Changed in tripleo:
assignee: nobody → Alex Schultz (alex-schultz)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/472847
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=84e37fe8c7b10b7aceb7c97ffb97ede5480ea5ee
Submitter: Jenkins
Branch: master

commit 84e37fe8c7b10b7aceb7c97ffb97ede5480ea5ee
Author: Alex Schultz <email address hidden>
Date: Fri Jun 9 15:55:16 2017 -0600

    Fix rpms being installed via DeployArtifactURLs

    The deploy-artifacts.sh script is supposed to support installing rpms
    when provided by DeployArtifactUrls. The problem is that it uses yum to
    install which does not actually work unless the filename ends with .rpm.
    This change updates the script to rename the downloaded file to end with
    .rpm if it is an rpm so that it is properly installed.

    Change-Id: I048d2b4474f9efe424e98e3868f325704e9c352f
    Closes-Bug: #1697102

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 7.0.0.0b3

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/493866

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/493867

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/newton)

Reviewed: https://review.openstack.org/493867
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=43745b2d6914960a7d15a111b1d571aed355fd80
Submitter: Jenkins
Branch: stable/newton

commit 43745b2d6914960a7d15a111b1d571aed355fd80
Author: Alex Schultz <email address hidden>
Date: Fri Jun 9 15:55:16 2017 -0600

    Fix rpms being installed via DeployArtifactURLs

    The deploy-artifacts.sh script is supposed to support installing rpms
    when provided by DeployArtifactUrls. The problem is that it uses yum to
    install which does not actually work unless the filename ends with .rpm.
    This change updates the script to rename the downloaded file to end with
    .rpm if it is an rpm so that it is properly installed.

    Change-Id: I048d2b4474f9efe424e98e3868f325704e9c352f
    Closes-Bug: #1697102
    (cherry picked from commit 84e37fe8c7b10b7aceb7c97ffb97ede5480ea5ee)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/ocata)

Reviewed: https://review.openstack.org/493866
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=703ff06d0f11f2a8cfdab7ce524febabe6e42f9f
Submitter: Jenkins
Branch: stable/ocata

commit 703ff06d0f11f2a8cfdab7ce524febabe6e42f9f
Author: Alex Schultz <email address hidden>
Date: Fri Jun 9 15:55:16 2017 -0600

    Fix rpms being installed via DeployArtifactURLs

    The deploy-artifacts.sh script is supposed to support installing rpms
    when provided by DeployArtifactUrls. The problem is that it uses yum to
    install which does not actually work unless the filename ends with .rpm.
    This change updates the script to rename the downloaded file to end with
    .rpm if it is an rpm so that it is properly installed.

    Change-Id: I048d2b4474f9efe424e98e3868f325704e9c352f
    Closes-Bug: #1697102
    (cherry picked from commit 84e37fe8c7b10b7aceb7c97ffb97ede5480ea5ee)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 5.3.1

This issue was fixed in the openstack/tripleo-heat-templates 5.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 6.2.1

This issue was fixed in the openstack/tripleo-heat-templates 6.2.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.