external_dns_driver causes floating ip association to fail

Bug #1696889 reported by Daniel Russell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Daniel Russell

Bug Description

If you have 'external_dns_driver = designate' set in neutron.conf and then attempt to associate a floating IP address with an instance, and the instance's network is not present in the 'networkdnsdomains' table, the following error occurs :

for field in potential_fields
  File "/usr/lib/python2.7/site-packages/neutron/objects/base.py", line 368, in <dictcomp>
    if db_obj.get(field) is not None}
AttributeError: 'NoneType' object has no attribute 'get'

Revision history for this message
Daniel Russell (danielr-2) wrote :

I believe this is because in /usr/lib/python2.7/site-packages/neutron/objects/network.py, in the get_net_dns_from_port function, it doesn't check if net_dns is None before attempting to load the (possibly None) object.

Changed in neutron:
assignee: nobody → Daniel Russell (danielr-2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/472494

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/472494
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ed27436c0687785075660cf9583bfd3c6fba9727
Submitter: Jenkins
Branch: master

commit ed27436c0687785075660cf9583bfd3c6fba9727
Author: Daniel Russell <email address hidden>
Date: Fri Jun 9 11:50:15 2017 +1000

    Checks if net_dns is None and returns so that we don't attempt to load
    None objects

    Change-Id: I2542fa2a77fc7d0689018564b9e83174b968e5fc
    Closes-Bug: #1696889

Changed in neutron:
status: In Progress → Fix Released
tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/474005

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ocata)

Reviewed: https://review.openstack.org/474005
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=87e32ebf4224b8a5df5bf6ba2ad2360393a374fb
Submitter: Jenkins
Branch: stable/ocata

commit 87e32ebf4224b8a5df5bf6ba2ad2360393a374fb
Author: Daniel Russell <email address hidden>
Date: Fri Jun 9 11:50:15 2017 +1000

    Checks if net_dns is None and returns so that we don't attempt to load
    None objects

    Change-Id: I2542fa2a77fc7d0689018564b9e83174b968e5fc
    Closes-Bug: #1696889
    (cherry picked from commit ed27436c0687785075660cf9583bfd3c6fba9727)

tags: added: in-stable-ocata
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b3

This issue was fixed in the openstack/neutron 11.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 10.0.3

This issue was fixed in the openstack/neutron 10.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.