Installation depends on requests package

[Stefan Wrobel]

I'm relatively new to Python, so my understanding might be lacking, but it seems that setup.py imports the whole library, which in turn depends on requests. Even if requests is earlier in requirements.txt, pip3 install will fail with "ModuleNotFoundError: No module named 'requests'"

See:
https://github.com/dustinkirkland/ssh-import-id/blob/master/setup.py#L20
https://github.com/dustinkirkland/ssh-import-id/blob/master/ssh_import_id/__init__.py

Similar to:
https://github.com/thiagofa/pysendy/pull/1

[Dustin Kirkland  (kirkland)]

Hmm, what's your proposed solution? Can you propose a patch?

[Stefan Wrobel (swrobel)]

Since the issue seems to be the same as it was for pysendy, where the version is being grabbed from __init__.py, you can either hardcode it in setup.py or add another version.py file that simply contains the version number and import that in both places. Unfortunately I have no idea how to submit a patch here...

See: https://github.com/thiagofa/pysendy/pull/1/files

[Scott Moser (smoser)]

I've fixed this in setup.py now, somewhat hackily.
but basically we avoid importing ssh_import_id, but directly import version.

please let me know if it is not working for you.

[Scott Moser (smoser)]

This bug is fixed in the 5.8 release.