Xaml export misses some radialGradients

Bug #1695016 reported by Mathieu GRENET
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
Mathieu GRENET
0.92.x
Fix Released
Low
Mathieu GRENET

Bug Description

a typo in svg2xaml.xsl prevent radial gradients to be converted.

I attached un example svg file with a patch (generated with winmerge I don't know if it is ok)

Inkscape 0.92.1 r15371

Tags: exporting xaml
Revision history for this message
Mathieu GRENET (mgth) wrote :
Revision history for this message
jazzynico (jazzynico) wrote :

Thanks for the patch! We usually use an unified diff format, but don't worry, your file is perfectly usable, and it's great you took some time to investigate and find a fix!

I'll try to test it a bit later. If everything is ok (and as the patch is pretty straightforward, I'd say there's no reason to not accept it), it will be included in 0.93, and very likely ported to the 0.92.x branch (and available in the next 0.92.2 version).

Thanks again!

Changed in inkscape:
assignee: nobody → jazzynico (jazzynico)
importance: Undecided → Low
milestone: none → 0.93
status: New → In Progress
Revision history for this message
jazzynico (jazzynico) wrote :

Fixed in the trunk rev. 15730.
Thanks for the patch, Mathieu!

Changed in inkscape:
assignee: jazzynico (jazzynico) → Mathieu GRENET (mgth)
status: In Progress → Fix Committed
Revision history for this message
jazzynico (jazzynico) wrote :

And backported to the lp:inkscape/0.92.x rev. 15434.

Revision history for this message
Mathieu GRENET (mgth) wrote :

Sorry, I did it wrong.
Testing with a bunch of svg I saw that Radial gradients often reference Linear Gradient Too.
So the best way I found is to simply remove the condition so it always work. Maybe people more aware than me could tell if there might be side effects.

I corrected some other problems in the patch with gradient origin and non significant 0.
Again sorry for my initial misunderstanding.

Revision history for this message
Mathieu GRENET (mgth) wrote :
Max Gaukler (mgmax)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.