Snapcraft

source-type: git uses --remote for submodules

Bug #1694765 reported by Michał Sawicz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Fix Released
Medium
Michał Sawicz
Snapcraft 2.31

Bug Description

https://github.com/snapcore/snapcraft/commit/d22880fdcee434a5e85c376e8f26c61a661231ce introduced `--remote` to `git submodule update` calls.

If I understand the git manual right [1], this actually updates to HEAD from the remote repository, effectively ignoring the commit recorded in the superproject.

This sounds really wrong as this means the superproject loses control over the submodule checkout.

[1] https://git-scm.com/docs/git-submodule#git-submodule---remote

Michał Sawicz (saviq)
Changed in snapcraft:
status: New → In Progress
assignee: nobody → Michał Sawicz (saviq)
Revision history for this message
Michał Sawicz (saviq) wrote :

PR: https://github.com/snapcore/snapcraft/pull/1344/files

Sergio Schvezov (sergiusens)
Changed in snapcraft:
importance: Undecided → Medium
status: In Progress → Fix Committed
milestone: none → 2.31
Kyle Fazzari (kyrofa)
Changed in snapcraft:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.