neutron-dvs-agent startup errors

[Stefan Nica]

I'm getting the following error while trying to start the DVS agent:

2017-05-29 12:01:56.299 17472 CRITICAL neutron [-] AttributeError: 'module' object has no attribute 'L2_AGENT_TOPIC'
2017-05-29 12:01:56.299 17472 ERROR neutron Traceback (most recent call last):
2017-05-29 12:01:56.299 17472 ERROR neutron File "/work/git/openstack/networking-vsphere/.venv/bin/neutron-dvs-agent", line 10, in <module>
2017-05-29 12:01:56.299 17472 ERROR neutron sys.exit(main())
2017-05-29 12:01:56.299 17472 ERROR neutron File "/work/git/openstack/networking-vsphere/networking_vsphere/agent/dvs_neutron_agent.py", line 428, in main
2017-05-29 12:01:56.299 17472 ERROR neutron agent = DVSAgent(**agent_config)
2017-05-29 12:01:56.299 17472 ERROR neutron File "/work/git/openstack/networking-vsphere/networking_vsphere/agent/dvs_neutron_agent.py", line 66, in __init__
2017-05-29 12:01:56.299 17472 ERROR neutron 'topic': n_const.L2_AGENT_TOPIC,
2017-05-29 12:01:56.299 17472 ERROR neutron AttributeError: 'module' object has no attribute 'L2_AGENT_TOPIC'
2017-05-29 12:01:56.299 17472 ERROR neutron

Initial investigation reveals that is caused because the L2_AGENT_TOPIC has been moved from neutron.common.constants to neutron_lib.constants. Fixing this manually reveals another error:

2017-05-29 12:17:29.006 18724 CRITICAL neutron [-] NoSuchOptError: no such option report_interval in group [DVS_AGENT]
2017-05-29 12:17:29.006 18724 ERROR neutron Traceback (most recent call last):
2017-05-29 12:17:29.006 18724 ERROR neutron File "/work/git/openstack/networking-vsphere/.venv/bin/neutron-dvs-agent", line 10, in <module>
2017-05-29 12:17:29.006 18724 ERROR neutron sys.exit(main())
2017-05-29 12:17:29.006 18724 ERROR neutron File "/work/git/openstack/networking-vsphere/networking_vsphere/agent/dvs_neutron_agent.py", line 428, in main
2017-05-29 12:17:29.006 18724 ERROR neutron agent = DVSAgent(**agent_config)
2017-05-29 12:17:29.006 18724 ERROR neutron File "/work/git/openstack/networking-vsphere/networking_vsphere/agent/dvs_neutron_agent.py", line 72, in __init__
2017-05-29 12:17:29.006 18724 ERROR neutron report_interval = cfg.CONF.DVS_AGENT.report_interval
2017-05-29 12:17:29.006 18724 ERROR neutron File "/work/git/openstack/networking-vsphere/.venv/lib/python2.7/site-packages/oslo_config/cfg.py", line 3273, in __getattr__
2017-05-29 12:17:29.006 18724 ERROR neutron return self._conf._get(name, self._group)
2017-05-29 12:17:29.006 18724 ERROR neutron File "/work/git/openstack/networking-vsphere/.venv/lib/python2.7/site-packages/oslo_config/cfg.py", line 2837, in _get
2017-05-29 12:17:29.006 18724 ERROR neutron value = self._do_get(name, group, namespace)
2017-05-29 12:17:29.006 18724 ERROR neutron File "/work/git/openstack/networking-vsphere/.venv/lib/python2.7/site-packages/oslo_config/cfg.py", line 2854, in _do_get
2017-05-29 12:17:29.006 18724 ERROR neutron info = self._get_opt_info(name, group)
2017-05-29 12:17:29.006 18724 ERROR neutron File "/work/git/openstack/networking-vsphere/.venv/lib/python2.7/site-packages/oslo_config/cfg.py", line 3009, in _get_opt_info
2017-05-29 12:17:29.006 18724 ERROR neutron raise NoSuchOptError(opt_name, group)
2017-05-29 12:17:29.006 18724 ERROR neutron NoSuchOptError: no such option report_interval in group [DVS_AGENT]
2017-05-29 12:17:29.006 18724 ERROR neutron

The report_interval configuration option has not been defined as part of the DVS_AGENT config group.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/468849

[OpenStack Infra (hudson-openstack)]

Change abandoned by 1912294464 (<email address hidden>) on branch: master
Review: https://review.openstack.org/535648

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/468849
Committed: https://git.openstack.org/cgit/openstack/networking-vsphere/commit/?id=11f75633ef3fd68346be4312943f9478702f8a67
Submitter: Zuul
Branch: master

commit 11f75633ef3fd68346be4312943f9478702f8a67
Author: Stefan Nica <email address hidden>
Date: Mon May 29 12:23:36 2017 +0200

    Fix neutron-dvs-agent startup errors

    The DVS agent complains about missing L2_AGENT_TOPIC
    constant and report_interval configuration option
    during startup. This changeset corrects these problems.

    Closes-Bug: 1694239
    Change-Id: I055bb7057e7ee67ea7dd1d30f4e1fc136b196e61

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/593680

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/593680
Committed: https://git.openstack.org/cgit/openstack/networking-vsphere/commit/?id=442f538251a4cf3f496ce2911d290a05eb04e8d3
Submitter: Zuul
Branch: stable/queens

commit 442f538251a4cf3f496ce2911d290a05eb04e8d3
Author: Stefan Nica <email address hidden>
Date: Mon May 29 12:23:36 2017 +0200

    Fix neutron-dvs-agent startup errors

    The DVS agent complains about missing L2_AGENT_TOPIC
    constant and report_interval configuration option
    during startup. This changeset corrects these problems.

    Closes-Bug: 1694239
    Change-Id: I055bb7057e7ee67ea7dd1d30f4e1fc136b196e61
    (cherry picked from commit 11f75633ef3fd68346be4312943f9478702f8a67)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/682482

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/682482
Committed: https://git.openstack.org/cgit/x/networking-vsphere/commit/?id=6b2ee6c91c6c898fa5a63e39025dcd30ae9ce41b
Submitter: Zuul
Branch: stable/pike

commit 6b2ee6c91c6c898fa5a63e39025dcd30ae9ce41b
Author: Stefan Nica <email address hidden>
Date: Mon May 29 12:23:36 2017 +0200

    Fix neutron-dvs-agent startup errors

    The DVS agent complains about missing L2_AGENT_TOPIC
    constant and report_interval configuration option
    during startup. This changeset corrects these problems.

    Closes-Bug: 1694239
    Change-Id: I055bb7057e7ee67ea7dd1d30f4e1fc136b196e61
    (cherry picked from commit 442f538251a4cf3f496ce2911d290a05eb04e8d3)