PFs with vlan are not being reported via devices metadata

[Vladik Romanovsky]

In some cases, Physical functions with VLAN are not being reported via the device's metadata, since info_cache shows as empty. Refreshing the info_cache before metadata creation solves the problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/468758

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/468758
Reason: Fixed in https://review.openstack.org/#/c/403568/.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/533805
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=abd01a757b8a83d714a6ab8b5085e7cc1b4a2c5c
Submitter: Zuul
Branch: master

commit abd01a757b8a83d714a6ab8b5085e7cc1b4a2c5c
Author: Artom Lifshitz <email address hidden>
Date: Mon Jan 15 15:52:11 2018 -0500

    Consider hostdev devices when building metadata

    Previously, device role tagging metadata would only be built for
    LibvirtConfigGuestInterface and LibvirtConfigGuestDisk. This didn't
    account for passed through PFs, which can also be tagged and appear as
    <hostdev> in the libvirt XML. This caused device role tagging to not
    work for PFs. This patch adds support for <hostdev> devices to
    _build_device_metadata.

    Change-Id: I24e5ff1b446f2ac41d589c026ce8ee8adad4bcbc
    Closes-bug: 1743458
    Closes-bug: 1694183

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/581399

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 18.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/581399
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e57f66a26daf858d1348c8406108a33a323b7b2e
Submitter: Zuul
Branch: stable/queens

commit e57f66a26daf858d1348c8406108a33a323b7b2e
Author: Artom Lifshitz <email address hidden>
Date: Mon Jan 15 15:52:11 2018 -0500

    Consider hostdev devices when building metadata

    Previously, device role tagging metadata would only be built for
    LibvirtConfigGuestInterface and LibvirtConfigGuestDisk. This didn't
    account for passed through PFs, which can also be tagged and appear as
    <hostdev> in the libvirt XML. This caused device role tagging to not
    work for PFs. This patch adds support for <hostdev> devices to
    _build_device_metadata.

    NOTE(artom): Conflicts in nova/tests/unit/virt/libvirt/test_driver.py
    due to trusted VFs not being present in Queens.

    Change-Id: I24e5ff1b446f2ac41d589c026ce8ee8adad4bcbc
    Closes-bug: 1743458
    Closes-bug: 1694183
    (cherry picked from commit abd01a757b8a83d714a6ab8b5085e7cc1b4a2c5c)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/587249

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.6 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/587249
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5ddcda02a8500ef88ee22b2cabf6d23527ad8de8
Submitter: Zuul
Branch: stable/pike

commit 5ddcda02a8500ef88ee22b2cabf6d23527ad8de8
Author: Artom Lifshitz <email address hidden>
Date: Mon Jan 15 15:52:11 2018 -0500

    Consider hostdev devices when building metadata

    Previously, device role tagging metadata would only be built for
    LibvirtConfigGuestInterface and LibvirtConfigGuestDisk. This didn't
    account for passed through PFs, which can also be tagged and appear as
    <hostdev> in the libvirt XML. This caused device role tagging to not
    work for PFs. This patch adds support for <hostdev> devices to
    _build_device_metadata.

    NOTE(artom): Queens -> Pike backport is clean, conflicts in
    nova/tests/unit/virt/libvirt/test_driver.py in Queens due to trusted
    VFs not being present.

    Change-Id: I24e5ff1b446f2ac41d589c026ce8ee8adad4bcbc
    Closes-bug: 1743458
    Closes-bug: 1694183
    (cherry picked from commit abd01a757b8a83d714a6ab8b5085e7cc1b4a2c5c)
    (cherry picked from commit e57f66a26daf858d1348c8406108a33a323b7b2e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.1.7 release.